From: Eric Biggers <ebiggers3@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org,
ebiggers@google.com, mhalcrow@google.com, richard@nod.at,
linux-ext4@vger.kernel.org, linux-f2fs@vger.kernel.org
Subject: Re: Creating a mailing list, git tree, and patchwork project for fscrypt
Date: Fri, 16 Dec 2016 14:25:09 -0800 [thread overview]
Message-ID: <20161216222509.GD14264@gmail.com> (raw)
In-Reply-To: <20161216220419.znasf5wjkpb7qazr@thunk.org>
On Fri, Dec 16, 2016 at 05:04:19PM -0500, Theodore Ts'o wrote:
> On Fri, Dec 16, 2016 at 12:53:30PM -0800, Eric Biggers wrote:
> > Sounds great!
> >
> > I guess it will be "fscrypt" and not "fscrypto"? There has been some confusion
> > about which term to use but it seems to be settling on "fscrypt".
>
> It was originally fscrypt, but then fscrypto crept in when we
> refactored the out to the fs/crypto directory from fs/ext4. I was
> planning on cleaning that up before we had too many file systems users
> of fscrypt that we would need to synchronzie with, but it'll be easier
> to do this as a separate git tree. We can either do it at the very
> beginning of the merge window (and have all of the file systems pull
> the change into fs/crypt), or I can work with Linus to do it right
> after the next next merge window closes.
>
> My preferences would be for the former, given where we are in the
> development cycle.
>
I'm fine with fscrypt. With regards to the cleanup, are you referring to
renaming the header fscrypto.h to fscrypt.h? Fortunately there aren't a lot
places that "fscrypto" actually appears in the tree --- basically just that
header, the module name, a couple log messages, and the MAINTAINERS file:
MAINTAINERS:FS-CRYPTO: FILE SYSTEM LEVEL ENCRYPTION SUPPORT
MAINTAINERS:F: include/linux/fscrypto.h
fs/crypto/Makefile:obj-$(CONFIG_FS_ENCRYPTION) += fscrypto.o
fs/crypto/Makefile:fscrypto-y := crypto.o fname.o policy.o keyinfo.o
fs/crypto/Makefile:fscrypto-$(CONFIG_BLOCK) += bio.o
fs/crypto/fscrypt_private.h:#include <linux/fscrypto.h>
fs/crypto/keyinfo.c: pr_warn_once("fscrypto: unsupported contents encryption mode "
fs/crypto/keyinfo.c: pr_warn_once("fscrypto: unsupported filenames encryption mode "
fs/crypto/keyinfo.c: pr_warn_once("fscrypto: unsupported file type %d for inode %lu\n",
fs/ext4/ext4.h:#include <linux/fscrypto.h>
fs/ext4/page-io.c:#include <linux/fscrypto.h>
fs/f2fs/f2fs.h:#include <linux/fscrypto.h>
fs/ubifs/ubifs.h:#include <linux/fscrypto.h>
include/linux/fscrypto.h:#ifndef _LINUX_FSCRYPTO_H
include/linux/fscrypto.h:#define _LINUX_FSCRYPTO_H
include/linux/fscrypto.h:#endif /* _LINUX_FSCRYPTO_H */
Eric
next prev parent reply other threads:[~2016-12-16 22:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 20:37 Creating a mailing list, git tree, and patchwork project for fscrypt Theodore Ts'o
2016-12-16 20:39 ` Richard Weinberger
2016-12-16 20:53 ` Eric Biggers
2016-12-16 22:04 ` Theodore Ts'o
2016-12-16 22:25 ` Eric Biggers [this message]
2017-03-29 21:14 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161216222509.GD14264@gmail.com \
--to=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mhalcrow@google.com \
--cc=richard@nod.at \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).