From: kbuild test robot <lkp@intel.com>
To: Lukas Czerner <lczerner@redhat.com>
Cc: kbuild-all@01.org, linux-fsdevel@vger.kernel.org,
viro@zeniv.linux.org.uk, jack@suse.cz,
Lukas Czerner <lczerner@redhat.com>,
Jeff Moyer <jmoyer@redhat.com>
Subject: Re: [PATCH] fs: Fix page cache inconsistency when mixing buffered and AIO DIO
Date: Fri, 14 Jul 2017 18:41:52 +0800 [thread overview]
Message-ID: <201707141843.JyuUd8pr%fengguang.wu@intel.com> (raw)
In-Reply-To: <1499959036-9275-1-git-send-email-lczerner@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 2212 bytes --]
Hi Lukas,
[auto build test WARNING on linus/master]
[also build test WARNING on v4.12 next-20170713]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Lukas-Czerner/fs-Fix-page-cache-inconsistency-when-mixing-buffered-and-AIO-DIO/20170714-181130
config: x86_64-randconfig-x010-201728 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
fs/iomap.c: In function 'iomap_dio_complete':
>> fs/iomap.c:629:25: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
(offset + dio->size + ret - 1) >> PAGE_SHIFT);
~~~~~~~~~~~~~~~~~~~^~~~~
vim +/ret +629 fs/iomap.c
618
619 static ssize_t iomap_dio_complete(struct iomap_dio *dio)
620 {
621 struct kiocb *iocb = dio->iocb;
622 loff_t offset = iocb->ki_pos;
623 struct inode *inode = file_inode(iocb->ki_filp);
624 ssize_t ret;
625
626 if ((dio->flags & IOMAP_DIO_WRITE) && inode->i_mapping->nrpages)
627 invalidate_inode_pages2_range(inode->i_mapping,
628 offset >> PAGE_SHIFT,
> 629 (offset + dio->size + ret - 1) >> PAGE_SHIFT);
630
631 if (dio->end_io) {
632 ret = dio->end_io(iocb,
633 dio->error ? dio->error : dio->size,
634 dio->flags);
635 } else {
636 ret = dio->error;
637 }
638
639 if (likely(!ret)) {
640 ret = dio->size;
641 /* check for short read */
642 if (iocb->ki_pos + ret > dio->i_size &&
643 !(dio->flags & IOMAP_DIO_WRITE))
644 ret = dio->i_size - iocb->ki_pos;
645 iocb->ki_pos += ret;
646 }
647
648 inode_dio_end(file_inode(iocb->ki_filp));
649 kfree(dio);
650
651 return ret;
652 }
653
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 24696 bytes --]
next prev parent reply other threads:[~2017-07-14 10:42 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 15:17 [PATCH] fs: Fix page cache inconsistency when mixing buffered and AIO DIO Lukas Czerner
2017-07-14 10:41 ` kbuild test robot [this message]
2017-07-14 13:40 ` Lukas Czerner
2017-07-14 15:40 ` [PATCH v2] " Lukas Czerner
2017-07-17 15:12 ` Jan Kara
2017-07-17 15:28 ` Lukas Czerner
2017-07-17 15:39 ` Jeff Moyer
2017-07-17 16:17 ` Jan Kara
2017-07-17 19:52 ` Jeff Moyer
2017-07-18 7:39 ` Lukas Czerner
2017-07-18 9:06 ` Jan Kara
2017-07-18 9:32 ` Lukas Czerner
2017-07-18 12:19 ` [PATCH v3] " Lukas Czerner
2017-07-18 13:44 ` Christoph Hellwig
2017-07-18 14:17 ` Jan Kara
2017-07-19 8:42 ` Lukas Czerner
2017-07-19 8:48 ` [PATCH v4] " Lukas Czerner
2017-07-19 9:26 ` Jan Kara
2017-07-19 11:01 ` Lukas Czerner
2017-07-19 11:28 ` [PATCH v5] " Lukas Czerner
2017-07-19 11:37 ` Jan Kara
2017-07-19 12:17 ` Jeff Moyer
2017-08-03 18:10 ` Jeff Moyer
2017-08-04 10:09 ` Dave Chinner
2017-08-07 15:52 ` Jeff Moyer
2017-08-08 8:41 ` Lukas Czerner
2017-08-10 12:59 ` [PATCH v6] " Lukas Czerner
2017-08-10 13:56 ` Jan Kara
2017-08-10 14:22 ` Jeff Moyer
2017-08-11 9:03 ` Lukas Czerner
2017-08-14 9:43 ` Jan Kara
2017-08-15 12:47 ` Lukas Czerner
2017-08-15 13:28 ` [PATCH v7] " Lukas Czerner
2017-08-16 13:15 ` Jan Kara
2017-08-16 16:01 ` Darrick J. Wong
2017-09-21 13:44 ` Jeff Moyer
2017-09-21 13:44 ` Lukas Czerner
2017-09-21 14:14 ` Jens Axboe
2017-10-10 14:34 ` David Sterba
2017-10-11 9:21 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201707141843.JyuUd8pr%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=kbuild-all@01.org \
--cc=lczerner@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).