From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 10 Aug 2017 05:11:39 -0700 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , Christoph Hellwig , Huang Ying , Andrew Morton , Alexander Viro , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 21/49] blk-merge: compute bio->bi_seg_front_size efficiently Message-ID: <20170810121139.GD14607@infradead.org> References: <20170808084548.18963-1-ming.lei@redhat.com> <20170808084548.18963-22-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170808084548.18963-22-ming.lei@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: On Tue, Aug 08, 2017 at 04:45:20PM +0800, Ming Lei wrote: > It is enough to check and compute bio->bi_seg_front_size just > after the 1st segment is found, but current code checks that > for each bvec, which is inefficient. > > This patch follows the way in __blk_recalc_rq_segments() > for computing bio->bi_seg_front_size, and it is more efficient > and code becomes more readable too. As far as I can tell this doesn't depend on anything else in the series and could be sent standalone? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org