From: Andrew Morton <akpm@linux-foundation.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Johannes Thumshirn <jthumshirn@suse.de>,
linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Toshi Kani <toshi.kani@hpe.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix mpage_writepage() for pages with buffers
Date: Tue, 10 Oct 2017 12:44:21 -0700 [thread overview]
Message-ID: <20171010124421.c545e6308fed5a585acd43cd@linux-foundation.org> (raw)
In-Reply-To: <20171006211541.GA7409@bombadil.infradead.org>
On Fri, 6 Oct 2017 14:15:41 -0700 Matthew Wilcox <willy@infradead.org> wrote:
> When using FAT on a block device which supports rw_page, we can hit
> BUG_ON(!PageLocked(page)) in try_to_free_buffers(). This is because we
> call clean_buffers() after unlocking the page we've written. Introduce a
> new clean_page_buffers() which cleans all buffers associated with a page
> and call it from within bdev_write_page().
This is all pretty mature code (isn't it?). Any idea why this bug
popped up now?
next prev parent reply other threads:[~2017-10-10 19:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 21:15 [PATCH] Fix mpage_writepage() for pages with buffers Matthew Wilcox
2017-10-09 10:41 ` Johannes Thumshirn
2017-10-10 19:44 ` Andrew Morton [this message]
2017-10-10 20:31 ` Linus Torvalds
2017-10-11 15:40 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010124421.c545e6308fed5a585acd43cd@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=jthumshirn@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=ross.zwisler@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=toshi.kani@hpe.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).