From: Al Viro <viro@ZenIV.linux.org.uk>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jan Kara <jack@suse.cz>, Deepa Dinamani <deepa.kernel@gmail.com>,
linux-fsdevel@vger.kernel.org, stable@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] isofs: fix timestamps beyond 2027
Date: Thu, 19 Oct 2017 12:51:05 +0100 [thread overview]
Message-ID: <20171019115104.GR21978@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20171019095027.588816-1-arnd@arndb.de>
On Thu, Oct 19, 2017 at 11:50:18AM +0200, Arnd Bergmann wrote:
> isofs uses a 'char' variable to load the number of years since
> 1900 for an inode timestamp. On architectures that use a signed
> char type by default, this results in an invalid date for
> anything beyond 2027.
>
> This adds a cast to 'u8' for the year number, which should extend
> the shelf life of the file system until 2155.
>
> This should be backported to all kernels that might still be
> in use by that date.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> fs/isofs/util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/isofs/util.c b/fs/isofs/util.c
> index 005a15cfd30a..f40796c4c6c2 100644
> --- a/fs/isofs/util.c
> +++ b/fs/isofs/util.c
> @@ -20,7 +20,7 @@ int iso_date(char * p, int flag)
> int year, month, day, hour, minute, second, tz;
> int crtime;
>
> - year = p[0];
> + year = (int)(u8)p[0];
This is BS; just turn that
char time[7];
in struct stamp into
unsigned char time[7];
and adjust iso_date() accordingly. Or make that
sucker actually take struct stamp *, while we are at it.
And I'd suggest going through the rest of on-disk structures in
rock.h and looking for other trouble of that sort.
next prev parent reply other threads:[~2017-10-19 11:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 9:50 [PATCH] isofs: fix timestamps beyond 2027 Arnd Bergmann
2017-10-19 11:51 ` Al Viro [this message]
2017-10-19 12:20 ` Anders Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019115104.GR21978@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).