From: Andrew Morton <akpm@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
David Howells <dhowells@redhat.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fat: Fix sb_rdonly() change
Date: Tue, 28 Nov 2017 14:41:27 -0800 [thread overview]
Message-ID: <20171128144127.e4903df58c8c3e7c783dd61b@linux-foundation.org> (raw)
In-Reply-To: <1511506294.8230.6.camel@perches.com>
On Thu, 23 Nov 2017 22:51:34 -0800 Joe Perches <joe@perches.com> wrote:
> On Fri, 2017-11-24 at 15:07 +0900, OGAWA Hirofumi wrote:
> > Joe Perches <joe@perches.com> writes:
> >
> > > On Thu, 2017-11-23 at 15:29 +0900, OGAWA Hirofumi wrote:
> > > > Ouch forgot to add stable@
> > > >
> > > > --
> > > > commit bc98a42c1f7d0f886c0c1b75a92a004976a46d9f introduced bug.
> > >
> > > I think your commit message needs a bit more information.
> > >
> > > It'd be useful to describe that the introduction of
> > > sb_rdonly converted the bitwise & to a boolean and so
> > > this conversion and comparison was made defective.
> > >
> > > Are there any other instances of defective comparisons?
> >
> > Please ask to that patch author.
>
> The patch author, David Howells, is on the cc list.
>
> btw:
>
> It seems all the the other uses use a (bool) cast of the
> (*flags & MS_RDONLY) and a comparison of sb_rdonly(sb).
Sentence is hard to understand.
> It would make sense to change the argument type of the
> ext[24]_setup_super int read_only arg to bool to match
> the sb_rdonly() type.
I did this:
: From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
: Subject: fat: Fix sb_rdonly() change
:
: bc98a42c1f7d0f ("VFS: Convert sb->s_flags & MS_RDONLY to sb_rdonly(sb)")
: converted fat_remount():new_rdonly from a bool to an int. However
: fat_remount() depends upon the compiler's conversion of a non-zero integer
: into boolean `true'.
:
: Fix it by switching `new_rdonly' back into a bool.
:
: Link: http://lkml.kernel.org/r/87mv3d5x51.fsf@mail.parknet.co.jp
: Fixes: bc98a42c1f7d0f8 ("VFS: Convert sb->s_flags & MS_RDONLY to sb_rdonly(sb)")
: Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
: Cc: Joe Perches <joe@perches.com>
: Cc: David Howells <dhowells@redhat.com>
: Cc: <stable@vger.kernel.org>
: Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
: ---
:
: fs/fat/inode.c | 2 +-
: 1 file changed, 1 insertion(+), 1 deletion(-)
:
: diff -puN fs/fat/inode.c~fat-fix-sb_rdonly-change fs/fat/inode.c
: --- a/fs/fat/inode.c~fat-fix-sb_rdonly-change
: +++ a/fs/fat/inode.c
: @@ -779,7 +779,7 @@ static void __exit fat_destroy_inodecach
:
: static int fat_remount(struct super_block *sb, int *flags, char *data)
: {
: - int new_rdonly;
: + bool new_rdonly;
: struct msdos_sb_info *sbi = MSDOS_SB(sb);
: *flags |= SB_NODIRATIME | (sbi->options.isvfat ? 0 : SB_NOATIME);
:
: _
prev parent reply other threads:[~2017-11-28 22:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 6:26 [PATCH] fat: Fix sb_rdonly() change OGAWA Hirofumi
2017-11-23 6:29 ` OGAWA Hirofumi
2017-11-23 20:49 ` Joe Perches
2017-11-24 6:07 ` OGAWA Hirofumi
2017-11-24 6:51 ` Joe Perches
2017-11-28 22:41 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128144127.e4903df58c8c3e7c783dd61b@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=joe@perches.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).