linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ernesto A. Fernández" <ernesto.mnd.fernandez@gmail.com>
To: Hin-Tak Leung <htl10@users.sourceforge.net>
Cc: linux-fsdevel@vger.kernel.org, tchou <tchou@synology.com>,
	"Alexander Viro" <viro@zeniv.linux.org.uk>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Ernesto A. Fernández" <ernesto.mnd.fernandez@gmail.com>,
	"Viacheslav Dubeyko" <slava@dubeyko.com>
Subject: Re: [PATCH] hfsplus: fix decomposition of Hangul characters
Date: Tue, 28 Nov 2017 20:10:29 -0300	[thread overview]
Message-ID: <20171128231028.GA4323@debian.home> (raw)
In-Reply-To: <1047295440.7535049.1511905720846@mail.yahoo.com>

On Tue, Nov 28, 2017 at 09:48:40PM +0000, Hin-Tak Leung wrote:
> --------------------------------------------
> On Tue, 28/11/17, Ernesto A. Fernández <ernesto.mnd.fernandez@gmail.com> wrote:
> 
> > Is that necessary? I think people can find the
> > Unicode Standard on their
> > own. Even if I did
> > provide a link, it's a pdf, so people would still
> > need
> > to look up the right sections. It's
> > not going to save anybody much work.
>  
> Yes, it is necessary. No, it is not a pdf. The code sample is inlined in the older version of this technical report:
> 
> http://www.unicode.org/reports/tr15/tr15-18.html#Hangul

This is extremely old, clearly not the version of Unicode I'm referencing.

> The code samples, etc had been splitted off and referenced in the current version:
> 
> http://www.unicode.org/reports/tr15/#Hangul_Composition

This does not link to the code sample at all, in fact it links to a page
that links to a page that links to a page that links to the pdf.

> Please:
> 1. include the above urls when you re-submit the next revision of the patch.
> 
> 2. include a brief description of minimal example - e.g. touch "\xXX\xYY\xZZ..." to create a minimal empty file for testing,
> in the commit message.

The way to test this patch is by creating a Hangul filename under MacOS
and trying to open it under linux, as the reporter did. You will not notice
anything wrong if you only work under linux.

> "People could look it up" is not an excuse not to give precise pointers to relevant information.
>

I would say "Section 3.12 of the Unicode Standard, version 10.0" is a very
precise pointer.

By the way, your mail client is making a huge mess of this thread; I have
no idea what message you are replying to anymore.

  reply	other threads:[~2017-11-28 23:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1047295440.7535049.1511905720846.ref@mail.yahoo.com>
2017-11-28 21:48 ` [PATCH] hfsplus: fix decomposition of Hangul characters Hin-Tak Leung
2017-11-28 23:10   ` Ernesto A. Fernández [this message]
2018-07-17 22:09 Ernesto A. Fernández
     [not found] <748914583.7912009.1511948801051.ref@mail.yahoo.com>
2017-11-29  9:46 ` Hin-Tak Leung
     [not found] <1691800505.7838608.1511945866988.ref@mail.yahoo.com>
2017-11-29  8:57 ` Hin-Tak Leung
2017-11-29 14:42   ` Ernesto A. Fernández
2017-11-29 16:28     ` Viacheslav Dubeyko
2017-11-30  4:03       ` Ernesto A. Fernández
     [not found] <114108759.7167494.1511886580033.ref@mail.yahoo.com>
2017-11-28 16:29 ` Hin-Tak Leung
     [not found] <1999104027.7153972.1511885718712.ref@mail.yahoo.com>
2017-11-28 16:15 ` Hin-Tak Leung
2017-11-28 17:50   ` Viacheslav Dubeyko
2017-11-28 18:51   ` Ernesto A. Fernández
  -- strict thread matches above, loose matches on Subject: below --
2017-11-17  8:20 [PATCH] hfsplus: fix the bug that cannot recognize files with hangul file name Ting-Chang Hou
2017-11-19  0:57 ` Ernesto A. Fernández
2017-11-23  3:57   ` tchou
2017-11-23 11:32     ` Ernesto A. Fernández
2017-11-24  7:25       ` tchou
2017-11-24 11:45         ` Ernesto A. Fernández
2017-11-27  2:07           ` tchou
2017-11-27 19:36             ` [PATCH] hfsplus: fix decomposition of Hangul characters Ernesto A. Fernández
2017-11-27 22:40               ` Viacheslav Dubeyko
2017-11-28 15:02                 ` Ernesto A. Fernández
2017-11-28 16:30                   ` Viacheslav Dubeyko
2017-11-28 18:15                     ` Ernesto A. Fernández
2018-08-23 18:29               ` Ernesto A. Fernández
2018-08-24  1:20                 ` tchou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171128231028.GA4323@debian.home \
    --to=ernesto.mnd.fernandez@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=htl10@users.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=slava@dubeyko.com \
    --cc=tchou@synology.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).