linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-mm@kvack.org, "zhangyi (F)" <yi.zhang@huawei.com>,
	linux-fsdevel@vger.kernel.org,
	Ross Zwisler <ross.zwisler@linux.intel.com>
Subject: Re: [PATCH v3] mm: Add unmap_mapping_pages
Date: Wed, 6 Dec 2017 11:26:15 -0700	[thread overview]
Message-ID: <20171206182615.GA22533@linux.intel.com> (raw)
In-Reply-To: <20171206142627.GD32044@bombadil.infradead.org>

On Wed, Dec 06, 2017 at 06:26:27AM -0800, Matthew Wilcox wrote:
> v3:
>  - Fix compilation
>    (I forgot to git commit --amend)
>  - Added Ross' Reviewed-by
> v2:
>  - Fix inverted mask in dax.c
>  - Pass 'false' instead of '0' for 'only_cows'
>  - nommu definition
> 
> --- 8< ---
> 
> From df142c51e111f7c386f594d5443530ea17abba5f Mon Sep 17 00:00:00 2001
> From: Matthew Wilcox <mawilcox@microsoft.com>
> Date: Tue, 5 Dec 2017 00:15:54 -0500
> Subject: [PATCH v3] mm: Add unmap_mapping_pages

Just FYI, the above scissors doesn't allow me to apply the patch using git
version 2.14.3:

  $ git am --scissors  ~/patch/out.patch
  Patch is empty.
  When you have resolved this problem, run "git am --continue".
  If you prefer to skip this patch, run "git am --skip" instead.
  To restore the original branch and stop patching, run "git am --abort".

It's mad about the second set of mail headers in the body of your mail, and
tries to separate into a second patch.

You can get around this either by a) not having the second set of headers
(From:, Date:, Subject:), or by including the extra info in a separate block
below the --- line, i.e.:

  ...
  Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>
  Reported-by: "zhangyi (F)" <yi.zhang@huawei.com>
  Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
  ---
  
  v3:
   - Fix compilation
     (I forgot to git commit --amend)
   - Added Ross' Reviewed-by
  v2:
   - Fix inverted mask in dax.c
   - Pass 'false' instead of '0' for 'only_cows'
   - nommu definition
  
  ---
   fs/dax.c           | 19 ++++++-------------
   include/linux/mm.h | 26 ++++++++++++++++----------
  ...

- Ross

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-12-06 18:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05 15:44 [PATCH v2] mm: Add unmap_mapping_pages Matthew Wilcox
2017-12-05 23:01 ` Ross Zwisler
2017-12-06 14:26 ` [PATCH v3] " Matthew Wilcox
2017-12-06 18:26   ` Ross Zwisler [this message]
2017-12-10 10:55   ` Kirill A. Shutemov
2017-12-08  2:10 ` [PATCH v2] " kbuild test robot
2017-12-08  2:38 ` kbuild test robot
2017-12-09  1:36   ` Matthew Wilcox
2017-12-09  2:42     ` Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171206182615.GA22533@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=willy@infradead.org \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).