From: Goldwyn Rodrigues <rgoldwyn@suse.de>
To: linux-fsdevel@vger.kernel.org
Cc: linux-block@vger.kernel.org, Goldwyn Rodrigues <rgoldwyn@suse.com>
Subject: [PATCH v7 1/2] xfs: remove assert to check bytes returned
Date: Thu, 8 Feb 2018 12:59:47 -0600 [thread overview]
Message-ID: <20180208185948.26827-1-rgoldwyn@suse.de> (raw)
From: Goldwyn Rodrigues <rgoldwyn@suse.com>
Since we can return less than count in case of partial direct
writes, remove the ASSERT.
Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
---
fs/xfs/xfs_file.c | 6 ------
1 file changed, 6 deletions(-)
Changes since v6:
- Reordered to before direct write fix
diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index 8601275cc5e6..8fc4dbf66910 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -590,12 +590,6 @@ xfs_file_dio_aio_write(
ret = iomap_dio_rw(iocb, from, &xfs_iomap_ops, xfs_dio_write_end_io);
out:
xfs_iunlock(ip, iolock);
-
- /*
- * No fallback to buffered IO on errors for XFS, direct IO will either
- * complete fully or fail.
- */
- ASSERT(ret < 0 || ret == count);
return ret;
}
--
2.16.1
next reply other threads:[~2018-02-08 18:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 18:59 Goldwyn Rodrigues [this message]
2018-02-08 18:59 ` [PATCH v7 2/2] Return bytes transferred for partial direct I/O Goldwyn Rodrigues
2018-03-08 0:53 ` Darrick J. Wong
2018-03-08 15:35 ` Goldwyn Rodrigues
2018-03-08 17:29 ` Darrick J. Wong
2018-05-20 1:29 ` Theodore Y. Ts'o
2018-05-20 13:54 ` Goldwyn Rodrigues
2018-02-09 4:52 ` [PATCH v7 1/2] xfs: remove assert to check bytes returned Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180208185948.26827-1-rgoldwyn@suse.de \
--to=rgoldwyn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rgoldwyn@suse.com \
--subject='Re: [PATCH v7 1/2] xfs: remove assert to check bytes returned' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).