From: Al Viro <viro@ZenIV.linux.org.uk>
To: Roman Gushchin <guro@fb.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH 3/3] dcache: account external names as indirectly reclaimable memory
Date: Tue, 13 Mar 2018 00:45:32 +0000 [thread overview]
Message-ID: <20180313004532.GU30522@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20180312223632.GA6124@castle>
On Mon, Mar 12, 2018 at 10:36:38PM +0000, Roman Gushchin wrote:
> Ah, I see...
>
> I think, it's better to account them when we're actually freeing,
> otherwise we will have strange path:
> (indirectly) reclaimable -> unreclaimable -> free
>
> Do you agree?
> +static void __d_free_external_name(struct rcu_head *head)
> +{
> + struct external_name *name;
> +
> + name = container_of(head, struct external_name, u.head);
> +
> + mod_node_page_state(page_pgdat(virt_to_page(name)),
> + NR_INDIRECTLY_RECLAIMABLE_BYTES,
> + -ksize(name));
> +
> + kfree(name);
> +}
Maybe, but then you want to call that from __d_free_external() and from
failure path in __d_alloc() as well. Duplicating something that convoluted
and easy to get out of sync is just asking for trouble.
next prev parent reply other threads:[~2018-03-13 0:45 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 13:37 [PATCH 0/3] indirectly reclaimable memory Roman Gushchin
2018-03-05 13:37 ` [PATCH 1/3] mm: introduce NR_INDIRECTLY_RECLAIMABLE_BYTES Roman Gushchin
2018-04-11 13:16 ` Vlastimil Babka
2018-04-11 13:56 ` Roman Gushchin
2018-04-12 6:52 ` Vlastimil Babka
2018-04-12 11:52 ` Michal Hocko
2018-04-12 14:38 ` Roman Gushchin
2018-04-12 14:46 ` Michal Hocko
2018-04-12 14:57 ` Roman Gushchin
2018-04-13 6:59 ` Michal Hocko
2018-04-13 12:13 ` vinayak menon
2018-04-25 3:49 ` Vijayanand Jitta
2018-04-25 12:52 ` Roman Gushchin
2018-04-25 15:47 ` Vlastimil Babka
2018-04-25 16:48 ` Roman Gushchin
2018-04-25 17:02 ` Vlastimil Babka
2018-04-25 17:23 ` Roman Gushchin
2018-04-25 15:55 ` Matthew Wilcox
2018-04-25 16:59 ` Vlastimil Babka
2018-03-05 13:37 ` [PATCH 2/3] mm: add indirectly reclaimable memory to MemAvailable Roman Gushchin
2018-03-05 13:47 ` Roman Gushchin
2018-03-05 13:37 ` [PATCH 2/3] mm: treat indirectly reclaimable memory as available in MemAvailable Roman Gushchin
2018-03-05 13:37 ` [PATCH 3/3] dcache: account external names as indirectly reclaimable memory Roman Gushchin
2018-03-12 21:17 ` Al Viro
2018-03-12 22:36 ` Roman Gushchin
2018-03-13 0:45 ` Al Viro [this message]
2018-04-05 22:11 ` Andrew Morton
2018-04-06 10:32 ` Roman Gushchin
2018-04-13 13:35 ` Minchan Kim
2018-04-13 13:59 ` Michal Hocko
2018-04-13 14:20 ` Vlastimil Babka
2018-04-13 14:28 ` Michal Hocko
2018-04-13 14:37 ` Johannes Weiner
2018-04-16 11:41 ` Michal Hocko
2018-04-16 12:06 ` Vlastimil Babka
2018-04-16 12:27 ` Michal Hocko
2018-04-16 19:57 ` Vlastimil Babka
2018-04-17 6:44 ` Michal Hocko
2018-04-16 13:09 ` Matthew Wilcox
2018-04-17 11:24 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313004532.GU30522@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).