From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:38394 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751814AbeCUJ1Q (ORCPT ); Wed, 21 Mar 2018 05:27:16 -0400 Date: Wed, 21 Mar 2018 10:27:13 +0100 From: Greg KH To: Christoph Hellwig Cc: viro@zeniv.linux.org.uk, Avi Kivity , linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 9/9] aio: implement IOCB_CMD_FSYNC and IOCB_CMD_FDSYNC Message-ID: <20180321092713.GR14085@kroah.com> References: <20180321073232.13366-1-hch@lst.de> <20180321073232.13366-10-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180321073232.13366-10-hch@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Mar 21, 2018 at 08:32:32AM +0100, Christoph Hellwig wrote: > Simple workqueue offload for now, but prepared for adding a real aio_fsync > method if the need arises. Based on an earlier patch from Dave Chinner. > > Signed-off-by: Christoph Hellwig > --- > fs/aio.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > > diff --git a/fs/aio.c b/fs/aio.c > index da87cbf7c67a..79d3eb3d2dd9 100644 > --- a/fs/aio.c > +++ b/fs/aio.c > @@ -156,9 +156,16 @@ struct kioctx { > unsigned id; > }; > > +struct fsync_iocb { > + struct work_struct work; > + struct file *file; > + bool datasync; > +}; > + > struct aio_kiocb { > union { > struct kiocb rw; > + struct fsync_iocb fsync; > }; > > struct kioctx *ki_ctx; > @@ -1565,6 +1572,43 @@ static ssize_t aio_write(struct kiocb *req, struct iocb *iocb, bool vectored, > return ret; > } > > +static void aio_fsync_work(struct work_struct *work) > +{ > + struct fsync_iocb *req = container_of(work, struct fsync_iocb, work); > + int ret; > + > + ret = vfs_fsync(req->file, req->datasync); > + fput(req->file); > + aio_complete(container_of(req, struct aio_kiocb, fsync), ret, 0); > +} > + > +static int aio_fsync(struct fsync_iocb *req, struct iocb *iocb, bool datasync) I hate the "bool" arguments to functions as you always need to go back and look them up. A "wrapper" of "aio_fsync_datasync()" and "aio_fsync_nodatasync()" around this maybe? Anyway, very tiny nit, not a big deal, it's your code, you can maintain it as-is :) Reviewed-by: Greg Kroah-Hartman