From: Goldwyn Rodrigues <rgoldwyn@suse.de>
To: linux-fsdevel@vger.kernel.org
Cc: linux-mm@kvack.org, willy@infradead.org, david@fromorbit.com,
Goldwyn Rodrigues <rgoldwyn@suse.com>
Subject: [PATCH 3/3] fs: Use memalloc_nofs_save in generic_perform_write
Date: Wed, 21 Mar 2018 17:44:29 -0500 [thread overview]
Message-ID: <20180321224429.15860-4-rgoldwyn@suse.de> (raw)
In-Reply-To: <20180321224429.15860-1-rgoldwyn@suse.de>
From: Goldwyn Rodrigues <rgoldwyn@suse.com>
Perform generic_perform_write() under memalloc_nofs because any allocations
should not recurse into fs writebacks.
This covers grab and write cache pages,
Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
---
mm/filemap.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/mm/filemap.c b/mm/filemap.c
index 3c9ead9a1e32..5fe54614c69f 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -36,6 +36,7 @@
#include <linux/cleancache.h>
#include <linux/shmem_fs.h>
#include <linux/rmap.h>
+#include <linux/sched/mm.h>
#include "internal.h"
#define CREATE_TRACE_POINTS
@@ -3105,6 +3106,7 @@ ssize_t generic_perform_write(struct file *file,
long status = 0;
ssize_t written = 0;
unsigned int flags = 0;
+ unsigned nofs_flags = memalloc_nofs_save();
do {
struct page *page;
@@ -3177,6 +3179,8 @@ ssize_t generic_perform_write(struct file *file,
balance_dirty_pages_ratelimited(mapping);
} while (iov_iter_count(i));
+ memalloc_nofs_restore(nofs_flags);
+
return written ? written : status;
}
EXPORT_SYMBOL(generic_perform_write);
--
2.16.2
next prev parent reply other threads:[~2018-03-21 22:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 22:44 [PATCH 0/3] fs: Use memalloc_nofs_save/restore scope API Goldwyn Rodrigues
2018-03-21 22:44 ` [PATCH 1/3] fs: Perform writebacks under memalloc_nofs Goldwyn Rodrigues
2018-03-22 7:08 ` Michal Hocko
2018-03-27 12:52 ` Goldwyn Rodrigues
2018-03-27 14:21 ` Matthew Wilcox
2018-03-27 15:13 ` Goldwyn Rodrigues
2018-03-27 16:45 ` Matthew Wilcox
2018-03-28 7:01 ` Michal Hocko
2018-03-28 23:57 ` Dave Chinner
2018-03-29 7:01 ` Michal Hocko
2018-03-31 21:21 ` Dave Chinner
2018-03-21 22:44 ` [PATCH 2/3] fs: use memalloc_nofs API while shrinking superblock Goldwyn Rodrigues
2018-03-22 7:09 ` Michal Hocko
2018-03-21 22:44 ` Goldwyn Rodrigues [this message]
2018-03-22 7:10 ` [PATCH 3/3] fs: Use memalloc_nofs_save in generic_perform_write Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180321224429.15860-4-rgoldwyn@suse.de \
--to=rgoldwyn@suse.de \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rgoldwyn@suse.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).