From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-block@vger.kernel.org, hch@lst.de, rdorr@microsoft.com
Subject: Re: [PATCH 3/3] iomap: Use FUA for pure data O_DSYNC DIO writes
Date: Wed, 28 Mar 2018 09:48:50 +0200 [thread overview]
Message-ID: <20180328074850.GE18726@lst.de> (raw)
In-Reply-To: <20180327070717.7107-4-david@fromorbit.com>
> if (iomap->flags & IOMAP_F_NEW)
> need_zeroout = true;
> + else {
Curly braces on both sides of the else, please.
> if (dio->flags & IOMAP_DIO_WRITE) {
> - bio_set_op_attrs(bio, REQ_OP_WRITE, REQ_SYNC | REQ_IDLE);
> + int op_flags = REQ_SYNC | REQ_IDLE;
> +
> + if (use_fua)
> + op_flags |= REQ_FUA;
> + else
> + dio->flags &= ~IOMAP_DIO_WRITE_FUA;
> + bio_set_op_attrs(bio, REQ_OP_WRITE, op_flags);
Please kill the bio_set_op_attrs flags while you are at it and assign
directly to bio->bi_opf:
bio->bi_opf = REQ_OP_WRITE | REQ_SYNC | REQ_IDLE;
if (use_fua)
bio->bi_opf |= REQ_FUA;
else
dio->flags &= ~IOMAP_DIO_WRITE_FUA;
> dio->flags |= IOMAP_DIO_WRITE;
> - if (iocb->ki_flags & IOCB_DSYNC)
> + if (iocb->ki_flags & IOCB_DSYNC) {
> dio->flags |= IOMAP_DIO_WRITE_SYNC;
> + /*
> + * Any non-FUA write will clear this flag, hence we know
> + * before completion whether a cache flush is necessary.
> + */
> + dio->flags |= IOMAP_DIO_WRITE_FUA;
I'd mention that we optimistically try fua first in the comment, and then
go on with what you wrote.
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index ed63f3b69c12..e853f1748a4b 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -800,6 +800,7 @@ static inline void queue_flag_clear(unsigned int flag, struct request_queue *q)
> #define blk_queue_quiesced(q) test_bit(QUEUE_FLAG_QUIESCED, &(q)->queue_flags)
> #define blk_queue_preempt_only(q) \
> test_bit(QUEUE_FLAG_PREEMPT_ONLY, &(q)->queue_flags)
> +#define blk_queue_fua(q) test_bit(QUEUE_FLAG_FUA, &(q)->queue_flags)
Separate patch, please.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2018-03-28 7:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 7:07 [PATCH 0/3 V2] iomap: Use FUA for O_DSYNC DIO writes Dave Chinner
2018-03-27 7:07 ` [PATCH 1/3] xfs: move generic_write_sync calls inwards Dave Chinner
2018-03-28 7:36 ` Christoph Hellwig
2018-03-27 7:07 ` [PATCH 2/3] iomap: iomap_dio_rw() handles all sync writes Dave Chinner
2018-03-28 7:38 ` Christoph Hellwig
2018-03-28 7:44 ` Christoph Hellwig
2018-03-27 7:07 ` [PATCH 3/3] iomap: Use FUA for pure data O_DSYNC DIO writes Dave Chinner
2018-03-28 7:48 ` Christoph Hellwig [this message]
2018-05-02 5:38 [PATCH 0/3 v3] iomap: Use FUA for " Dave Chinner
2018-05-02 5:38 ` [PATCH 3/3] iomap: Use FUA for pure data " Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180328074850.GE18726@lst.de \
--to=hch@lst.de \
--cc=david@fromorbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=rdorr@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).