From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:54788 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750946AbeC2JG6 (ORCPT ); Thu, 29 Mar 2018 05:06:58 -0400 Date: Thu, 29 Mar 2018 05:01:32 -0400 From: Richard Guy Briggs To: Jonathan Corbet Cc: cgroups@vger.kernel.org, containers@lists.linux-foundation.org, linux-api@vger.kernel.org, Linux-Audit Mailing List , linux-fsdevel@vger.kernel.org, LKML , netdev@vger.kernel.org, luto@kernel.org, jlayton@redhat.com, carlos@redhat.com, viro@zeniv.linux.org.uk, dhowells@redhat.com, simo@redhat.com, eparis@parisplace.org, serge@hallyn.com, ebiederm@xmission.com, madzcar@gmail.com Subject: Re: [RFC PATCH ghak32 V2 01/13] audit: add container id Message-ID: <20180329090132.r3qfomigkw3hbwbw@madcap2.tricolour.ca> References: <20180328123912.49b11c98@lwn.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180328123912.49b11c98@lwn.net> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 2018-03-28 12:39, Jonathan Corbet wrote: > On Fri, 16 Mar 2018 05:00:28 -0400 > Richard Guy Briggs wrote: > > Implement the proc fs write to set the audit container ID of a process, > > emitting an AUDIT_CONTAINER record to document the event. > > A little detail, but still... I am understanding that you would prefer more context (as opposed to operational detail) in the description, laying out the use case for this patch(set)? > > +static int audit_set_containerid_perm(struct task_struct *task, u64 containerid) > > +{ > > + struct task_struct *parent; > > + u64 pcontainerid, ccontainerid; > > + > > + /* Don't allow to set our own containerid */ > > + if (current == task) > > + return -EPERM; > > + /* Don't allow the containerid to be unset */ > > + if (!cid_valid(containerid)) > > + return -EINVAL; > > I went looking for cid_valid(), but it turns out you don't add it until > patch 5. That, I expect, will not be good for bisectability (or patch > review). Nice catch, thanks Jon. That is very likely another victim of a git rebase to re-order afterthoughts in the right place. I'll need to be more careful of that class of bug, rethink my workflow, or script builds to verify each commit is compilable. > Thanks, > > jon - RGB -- Richard Guy Briggs Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635