From: Michal Hocko <mhocko@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH] mm: Check for SIGKILL inside dup_mmap() loop.
Date: Tue, 3 Apr 2018 13:16:40 +0200 [thread overview]
Message-ID: <20180403111640.GN5501@dhcp22.suse.cz> (raw)
In-Reply-To: <20180329143003.c52ada618be599c5358e8ca2@linux-foundation.org>
On Thu 29-03-18 14:30:03, Andrew Morton wrote:
[...]
> Dumb question: if a thread has been oom-killed and then tries to
> allocate memory, should the page allocator just fail the allocation
> attempt? I suppose there are all sorts of reasons why not :(
We give those tasks access to memory reserves to move on (see
oom_reserves_allowed) and fail allocation if reserves do not help
if (tsk_is_oom_victim(current) &&
(alloc_flags == ALLOC_OOM ||
(gfp_mask & __GFP_NOMEMALLOC)))
goto nopage;
So we...
> In which case, yes, setting a new
> PF_MEMALLOC_MAY_FAIL_IF_I_WAS_OOMKILLED around such code might be a
> tidy enough solution. It would be a bit sad to add another test in the
> hot path (should_fail_alloc_page()?), but geeze we do a lot of junk
> already.
... do not need this.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-04-03 11:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 11:27 [PATCH] mm: Check for SIGKILL inside dup_mmap() loop Tetsuo Handa
2018-03-29 21:30 ` Andrew Morton
2018-03-30 10:34 ` Tetsuo Handa
2018-04-03 12:14 ` Matthew Wilcox
2018-04-03 12:19 ` Michal Hocko
2018-04-03 12:25 ` Matthew Wilcox
2018-04-03 14:54 ` Tetsuo Handa
2018-04-03 12:29 ` Tetsuo Handa
2018-04-03 13:06 ` Michal Hocko
2018-04-03 11:16 ` Michal Hocko [this message]
2018-04-03 11:32 ` Tetsuo Handa
2018-04-03 11:38 ` Michal Hocko
2018-04-03 11:58 ` Matthew Wilcox
2018-04-03 12:08 ` Michal Hocko
2018-04-07 10:38 ` Tetsuo Handa
2018-04-18 21:44 ` Andrew Morton
2018-04-19 1:54 ` Tetsuo Handa
2018-04-19 2:32 ` Andrew Morton
2018-06-07 22:05 ` Andrew Morton
2018-06-08 17:05 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180403111640.GN5501@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=riel@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).