From: Peter Zijlstra <peterz@infradead.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: viro@zeniv.linux.org.uk, osandov@fb.com, dvyukov@google.com,
bot+abdba5bc6de135d7622f00756da97998425b6de5@syzkaller.appspotmail.com,
axboe@kernel.dk, tom.leiming@gmail.com, hare@suse.de,
shli@fb.com, linux-kernel@vger.kernel.org,
syzkaller-bugs@googlegroups.com, mingo@redhat.com,
linux-fsdevel@vger.kernel.org, knikanth@suse.de
Subject: Re: INFO: task hung in lo_ioctl
Date: Fri, 6 Apr 2018 17:43:43 +0200 [thread overview]
Message-ID: <20180406154343.GK4082@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <201804062255.HEJ82361.FJOFHVtSLOMOQF@I-love.SAKURA.ne.jp>
On Fri, Apr 06, 2018 at 10:55:03PM +0900, Tetsuo Handa wrote:
> Peter Zijlstra wrote:
> > On Fri, Apr 06, 2018 at 09:04:18PM +0900, Tetsuo Handa wrote:
> > > + /* Temporary hack for handling lock imbalance. */
> > > + if (__mutex_owner(&lo->lo_ctl_mutex) == current)
> > > + mutex_unlock(&lo->lo_ctl_mutex);
> >
> > ARGGH.. you didn't read the comment we put on that?
> >
>
> Commit 5b52330bbfe63b33 ("audit: fix auditd/kernel connection state tracking")
> is using __mutex_owner(). ;-)
That got removed and the warning added.
next prev parent reply other threads:[~2018-04-06 15:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <94eb2c0810d04f5a46055ffc71aa@google.com>
[not found] ` <CACT4Y+Y6UhNQOc7VUPgvXZ3yGPusjg2WJ9-OXMCRGM2Q1bx7ZQ@mail.gmail.com>
2018-04-04 15:23 ` INFO: task hung in lo_ioctl Tetsuo Handa
2018-04-06 12:04 ` Tetsuo Handa
2018-04-06 12:14 ` Peter Zijlstra
2018-04-06 13:55 ` Tetsuo Handa
2018-04-06 15:43 ` Peter Zijlstra [this message]
2018-04-06 15:59 ` Omar Sandoval
2019-01-19 18:56 ` Dmitry Vyukov
2019-01-20 2:35 ` Tetsuo Handa
2019-01-20 9:49 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180406154343.GK4082@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=axboe@kernel.dk \
--cc=bot+abdba5bc6de135d7622f00756da97998425b6de5@syzkaller.appspotmail.com \
--cc=dvyukov@google.com \
--cc=hare@suse.de \
--cc=knikanth@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=osandov@fb.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=shli@fb.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tom.leiming@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).