linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Sergej Schumilo <sergej@schumilo.de>,
	linux-fsdevel@vger.kernel.org, gregkh@linuxfoundation.org,
	jlayton@redhat.com, akpm@linux-foundation.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Cornelius Aschermann <cornelius.aschermann@ruhr-uni-bochum.de>
Subject: Re: Null-Pointer Deference in hfs.ko (Linux 4.15.0-15.16 Ubuntu)
Date: Wed, 18 Apr 2018 10:59:06 -0700	[thread overview]
Message-ID: <20180418175906.GB5197@magnolia> (raw)
In-Reply-To: <20180418173028.GA30953@bombadil.infradead.org>

On Wed, Apr 18, 2018 at 10:30:28AM -0700, Matthew Wilcox wrote:
> On Wed, Apr 18, 2018 at 06:26:41PM +0200, Sergej Schumilo wrote:
> > Dear all,
> > The following null pointer dereference bug was found by a modified version of the kAFL fuzzer (https://github.com/RUB-SysSec/kAFL). I have attached the causing hfs filesystem image, the dmesg report and the source code of a simple mounting tool to reproduce this issue.
> > 
> > A local users who have been granted the privileges necessary to mount filesystems (or a system components which auto mounts filesystems) could trigger a null pointer dereference or a kernel panic (depending on panic_on_oops).
> 
> I have to say this isn't going to rank very highly in terms of bugs we're
> likely to spend a lot of time on.  Almost nobody uses HFS on Linux,
> and it has no maintainer.  I'd suggest that Ubuntu disables it from
> their configuration, or if it's important to them, that they contribute
> somebody's time to working on it.
> 
> You'd probably get a more interesting response if you fuzzed ext4, btrfs
> or XFS.  Or FAT or iso9660; things people are likely to have an USB keys.
> There may be a tooling problem here where some filesystems should be
> whitelisted for automounting.  I just don't think you're going to find
> anyone interested in fixing this.

They already are fuzzing ext4 and xfs and generating a fair amount of
list / bugzilla traffic.  Regrettable that almost nobody sends us
patches to fix the things they find, which at some point is just going
to make the review backlog problems worse as peoples' attention get
diverted to triaging the flood of reports.

Sorry just being a grumpy maintainer.

--D

  parent reply	other threads:[~2018-04-18 18:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18 16:26 Null-Pointer Deference in hfs.ko (Linux 4.15.0-15.16 Ubuntu) Sergej Schumilo
2018-04-18 17:30 ` Matthew Wilcox
2018-04-18 17:54   ` Eric Biggers
2018-04-19  2:43     ` Matthew Wilcox
2018-04-18 17:59   ` Darrick J. Wong [this message]
2018-04-19  1:44     ` Dave Chinner
2018-04-19  2:15       ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180418175906.GB5197@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=cornelius.aschermann@ruhr-uni-bochum.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jlayton@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=sergej@schumilo.de \
    --cc=torvalds@linux-foundation.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).