From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:43870 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750799AbeDSIZD (ORCPT ); Thu, 19 Apr 2018 04:25:03 -0400 Date: Thu, 19 Apr 2018 10:24:56 +0200 From: Greg KH To: Rahul Lakkireddy Cc: netdev@vger.kernel.org, kexec@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, viro@zeniv.linux.org.uk, ebiederm@xmission.com, stephen@networkplumber.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, ganeshgr@chelsio.com, nirranjan@chelsio.com, indranil@chelsio.com Subject: Re: [PATCH net-next v4 1/3] vmcore: add API to collect hardware dump in second kernel Message-ID: <20180419082456.GA8617@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Apr 17, 2018 at 01:14:17PM +0530, Rahul Lakkireddy wrote: > +config PROC_VMCORE_DEVICE_DUMP > + bool "Device Hardware/Firmware Log Collection" > + depends on PROC_VMCORE > + default y Only things that require the machine to keep working should be 'default y', please remove this, it's an option. > + help > + Device drivers can collect the device specific snapshot of > + their hardware or firmware before they are initialized in > + crash recovery kernel. If you say Y here, the device dumps > + will be added as ELF notes to /proc/vmcore Which exact "device drivers" are you referring to here? thanks, greg k-h