From: Michal Hocko <email@example.com>
To: firstname.lastname@example.org, Yang Shi <email@example.com>
Cc: firstname.lastname@example.org, email@example.com, firstname.lastname@example.org,
Subject: Re: [RFC v2 PATCH] mm: shmem: make stat.st_blksize return huge page size if THP is on
Date: Mon, 23 Apr 2018 09:04:35 -0600 [thread overview]
Message-ID: <20180423150435.GS17484@dhcp22.suse.cz> (raw)
On Sun 22-04-18 21:28:59, Yang Shi wrote:
> On 4/22/18 6:47 PM, Michal Hocko wrote:
> > will be used on the first aligned address even when the initial/last
> > portion of the mapping is not THP aligned.
> No, my test shows it is not. And, transhuge_vma_suitable() does check the
> virtual address alignment. If it is not huge page size aligned, it will not
> set PMD for huge page.
It's been quite some time since I've looked at that code but I think you
are wrong. It just doesn't make sense to make the THP decision on the
VMA alignment much. Kirill, can you clarify please?
Please note that I have no objections to actually export the huge page
size as the max block size but your changelog just doesn't make any
sense to me.
next prev parent reply other threads:[~2018-04-23 15:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 16:33 [RFC v2 PATCH] mm: shmem: make stat.st_blksize return huge page size if THP is on Yang Shi
2018-04-23 0:47 ` Michal Hocko
2018-04-23 3:28 ` Yang Shi
2018-04-23 15:04 ` Michal Hocko [this message]
2018-04-23 16:19 ` Yang Shi
2018-04-24 3:41 ` Yang Shi
2018-04-24 12:43 ` Michal Hocko
2018-04-24 13:08 ` Yang Shi
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).