linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/3 v3] iomap: Use FUA for O_DSYNC DIO writes
@ 2018-05-02  5:38 Dave Chinner
  2018-05-02  5:38 ` [PATCH 1/3] xfs: move generic_write_sync calls inwards Dave Chinner
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Dave Chinner @ 2018-05-02  5:38 UTC (permalink / raw)
  To: linux-xfs; +Cc: linux-fsdevel, linux-block, hch, rdorr

Hi folks,

Version 3 of the FUA for O-DSYNC patchset. This version fixes bugs
found in the previous version. Functionality is otherwise the same
as described in the first version:

https://marc.info/?l=linux-xfs&m=152213446528167&w=2

Version 3:

- fixed O_SYNC behaviour as noticed by Jan Kara
- fixed use after free on IO completion due
  iomap_dio_complete_work() simplification added in version 2. Found
  by KASAN when running xfstests.

Version 2:
- Fixed comment typos in first patch
- simplified iomap_dio_complete_work()
- changed IOMAP_DIO_WRITE_SYNC to IOMAP_DIO_NEED_SYNC
- split blk_queue_fua() into it's own patch
- fixed formatting issue in last patch
- update bio->io_opf directly rather than use bio_set_op_attrs()
- Updated comment to mention we try to use FUA optimistically.

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH 0/3 V2] iomap: Use FUA for O_DSYNC DIO writes
@ 2018-03-27  7:07 Dave Chinner
  2018-03-27  7:07 ` [PATCH 1/3] xfs: move generic_write_sync calls inwards Dave Chinner
  0 siblings, 1 reply; 7+ messages in thread
From: Dave Chinner @ 2018-03-27  7:07 UTC (permalink / raw)
  To: linux-xfs; +Cc: linux-fsdevel, linux-block, hch, rdorr

Hi folks,

This is a followup on my original patch to enable use of FUA writes
for pure data O_DSYNC writes through the XFS and iomap based direct
IO paths. This version has all of the changes christoph asked for,
and splits it up into simpler patches. The performance improvements
are detailed in the commit description of the third patch.

Changes from the original patch:
- put XFS generic_write_sync call de-factoring into it's own patch
- the change for iomap_dio_rw() to handle all aspects of O_DSYNC
  writes was pushed into it's own patch
- changed the flag and logic for tracking if FUA is in use though
  the iomap DIO paths
- only enable use of FUA is the underlying device supports FUA
  operations.

Thoughts and comments welcome.

Cheers,

Dave.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-05-02 20:09 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-02  5:38 [PATCH 0/3 v3] iomap: Use FUA for O_DSYNC DIO writes Dave Chinner
2018-05-02  5:38 ` [PATCH 1/3] xfs: move generic_write_sync calls inwards Dave Chinner
2018-05-02  5:38 ` [PATCH 2/3] iomap: iomap_dio_rw() handles all sync writes Dave Chinner
2018-05-02  5:38 ` [PATCH 3/3] iomap: Use FUA for pure data O_DSYNC DIO writes Dave Chinner
2018-05-02 20:09 ` [PATCH 0/3 v3] iomap: Use FUA for " Darrick J. Wong
  -- strict thread matches above, loose matches on Subject: below --
2018-03-27  7:07 [PATCH 0/3 V2] " Dave Chinner
2018-03-27  7:07 ` [PATCH 1/3] xfs: move generic_write_sync calls inwards Dave Chinner
2018-03-28  7:36   ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).