linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-block@vger.kernel.org, hch@lst.de, rdorr@microsoft.com
Subject: Re: [PATCH 0/3 v3] iomap: Use FUA for O_DSYNC DIO writes
Date: Wed, 2 May 2018 13:09:51 -0700	[thread overview]
Message-ID: <20180502200951.GB4127@magnolia> (raw)
In-Reply-To: <20180502053807.13846-1-david@fromorbit.com>

On Wed, May 02, 2018 at 03:38:04PM +1000, Dave Chinner wrote:
> Hi folks,
> 
> Version 3 of the FUA for O-DSYNC patchset. This version fixes bugs
> found in the previous version. Functionality is otherwise the same
> as described in the first version:
> 
> https://marc.info/?l=linux-xfs&m=152213446528167&w=2

Will test the whole series, consider this a tentative:
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> 
> Version 3:
> 
> - fixed O_SYNC behaviour as noticed by Jan Kara
> - fixed use after free on IO completion due
>   iomap_dio_complete_work() simplification added in version 2. Found
>   by KASAN when running xfstests.
> 
> Version 2:
> - Fixed comment typos in first patch
> - simplified iomap_dio_complete_work()
> - changed IOMAP_DIO_WRITE_SYNC to IOMAP_DIO_NEED_SYNC
> - split blk_queue_fua() into it's own patch
> - fixed formatting issue in last patch
> - update bio->io_opf directly rather than use bio_set_op_attrs()
> - Updated comment to mention we try to use FUA optimistically.
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2018-05-02 20:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-02  5:38 [PATCH 0/3 v3] iomap: Use FUA for O_DSYNC DIO writes Dave Chinner
2018-05-02  5:38 ` [PATCH 1/3] xfs: move generic_write_sync calls inwards Dave Chinner
2018-05-02  5:38 ` [PATCH 2/3] iomap: iomap_dio_rw() handles all sync writes Dave Chinner
2018-05-02  5:38 ` [PATCH 3/3] iomap: Use FUA for pure data O_DSYNC DIO writes Dave Chinner
2018-05-02 20:09 ` Darrick J. Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180502200951.GB4127@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=rdorr@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).