From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: jack@suse.cz, linux-fsdevel@vger.kernel.org
Cc: linux-block@vger.kernel.org, axboe@kernel.dk, tj@kernel.org,
david@fromorbit.com
Subject: Re: [PATCH] bdi: Fix oops in wb_workfn()
Date: Fri, 4 May 2018 07:35:34 +0900 [thread overview]
Message-ID: <201805040735.ADG57320.VFOQOJMOLHFStF@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <20180503162626.27753-1-jack@suse.cz>
Jan Kara wrote:
> Make wb_workfn() use wakeup_wb() for requeueing the work which takes all
> the necessary precautions against racing with bdi unregistration.
Yes, this patch will solve NULL pointer dereference bug. But is it OK to leave
list_empty(&wb->work_list) == false situation? Who takes over the role of making
list_empty(&wb->work_list) == true?
Just a confirmation, for Fabiano Rosas is facing a problem that "write call
hangs in kernel space after virtio hot-remove" and is thinking that we might
need to go the opposite direction
( http://lkml.kernel.org/r/f0787b79-1e50-5f55-a400-44f715451777@linux.ibm.com ).
next prev parent reply other threads:[~2018-05-03 22:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 16:26 [PATCH] bdi: Fix oops in wb_workfn() Jan Kara
2018-05-03 21:55 ` Dave Chinner
2018-05-03 21:57 ` Jens Axboe
2018-05-09 9:48 ` Jan Kara
2018-05-03 22:35 ` Tetsuo Handa [this message]
2018-05-09 9:47 ` Jan Kara
2018-05-19 14:27 ` Tetsuo Handa
2018-05-21 9:38 ` Jan Kara
2018-05-25 10:15 ` Tetsuo Handa
2018-05-09 10:31 ` Jan Kara
2018-05-09 14:42 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201805040735.ADG57320.VFOQOJMOLHFStF@I-love.SAKURA.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).