From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Waiman Long <longman@redhat.com>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>,
Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-doc@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
Matthew Wilcox <willy@infradead.org>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH v7 1/4] ipc: IPCMNI limit check for msgmni and shmmni
Date: Wed, 9 May 2018 19:32:00 +0000 [thread overview]
Message-ID: <20180509193200.GU27853@wotan.suse.de> (raw)
In-Reply-To: <edcc0a97-fbec-f511-36d2-fea0e123b4ee@redhat.com>
On Mon, May 07, 2018 at 07:57:12PM -0400, Waiman Long wrote:
> On 05/07/2018 06:39 PM, Luis R. Rodriguez wrote:
> > On Mon, May 07, 2018 at 04:59:09PM -0400, Waiman Long wrote:
> >> A user can write arbitrary integer values to msgmni and shmmni sysctl
> >> parameters without getting error, but the actual limit is really
> >> IPCMNI (32k). This can mislead users as they think they can get a
> >> value that is not real.
> >>
> >> The right limits are now set for msgmni and shmmni so that the users
> >> will become aware if they set a value outside of the acceptable range.
> >>
> >> Signed-off-by: Waiman Long <longman@redhat.com>
> >> ---
> >> ipc/ipc_sysctl.c | 7 +++++--
> >> 1 file changed, 5 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/ipc/ipc_sysctl.c b/ipc/ipc_sysctl.c
> >> index 8ad93c2..f87cb29 100644
> >> --- a/ipc/ipc_sysctl.c
> >> +++ b/ipc/ipc_sysctl.c
> >> @@ -99,6 +99,7 @@ static int proc_ipc_auto_msgmni(struct ctl_table *table, int write,
> >> static int zero;
> >> static int one = 1;
> >> static int int_max = INT_MAX;
> >> +static int ipc_mni = IPCMNI;
> >>
> >> static struct ctl_table ipc_kern_table[] = {
> >> {
> >> @@ -120,7 +121,9 @@ static int proc_ipc_auto_msgmni(struct ctl_table *table, int write,
> >> .data = &init_ipc_ns.shm_ctlmni,
> >> .maxlen = sizeof(init_ipc_ns.shm_ctlmni),
> >> .mode = 0644,
> >> - .proc_handler = proc_ipc_dointvec,
> >> + .proc_handler = proc_ipc_dointvec_minmax,
> >> + .extra1 = &zero,
> >> + .extra2 = &ipc_mni,
> >> },
> >> {
> >> .procname = "shm_rmid_forced",
> >> @@ -147,7 +150,7 @@ static int proc_ipc_auto_msgmni(struct ctl_table *table, int write,
> >> .mode = 0644,
> >> .proc_handler = proc_ipc_dointvec_minmax,
> >> .extra1 = &zero,
> >> - .extra2 = &int_max,
> >> + .extra2 = &ipc_mni,
> >> },
> >> {
> >> .procname = "auto_msgmni",
> >> --
> >> 1.8.3.1
> > It seems negative values are not allowed, if true then having
> > a caller to use proc_douintvec_minmax() would help with ensuring
> > no invalid negative input values are used as well.
> >
> > Luis
>
> Negative value doesn't mean sense here. So it is true that we can use
> proc_douintvec_minmax() instead. However, the data types themselves are
> defined as "int". So I think it is better to keep using
> proc_dointvec_minmax() to be consistent with the data type.
Huh, no... If you *know* the valid values *are* only positive, the right
thing to do is to then *change* the data type. Tons of odd bugs can creep
up because of these stupid things.
Luis
next prev parent reply other threads:[~2018-05-09 19:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 20:59 [PATCH v7 0/4] ipc: IPCMNI limit check for *mni & increase that limit Waiman Long
2018-05-07 20:59 ` [PATCH v7 1/4] ipc: IPCMNI limit check for msgmni and shmmni Waiman Long
2018-05-07 22:39 ` Luis R. Rodriguez
2018-05-07 23:57 ` Waiman Long
2018-05-09 19:32 ` Luis R. Rodriguez [this message]
2018-06-18 9:52 ` Waiman Long
2018-05-07 20:59 ` [PATCH v7 2/4] ipc: IPCMNI limit check for semmni Waiman Long
2018-05-07 20:59 ` [PATCH v7 3/4] ipc: Allow boot time extension of IPCMNI from 32k to 2M Waiman Long
2018-05-07 23:17 ` Luis R. Rodriguez
2018-05-08 0:04 ` Waiman Long
2018-05-07 20:59 ` [PATCH v7 4/4] ipc: Conserve sequence numbers in extended IPCMNI mode Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180509193200.GU27853@wotan.suse.de \
--to=mcgrof@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).