From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org,
sandeen@sandeen.net, darrick.wong@oracle.com,
dhowells@redhat.com, tytso@mit.edu, fliu@suse.com, jack@suse.cz,
jeffm@suse.com, nborisov@suse.com, jake.norris@suse.com,
mtk.manpages@gmail.com, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] vfs: skip extra attributes check on removal for symlinks
Date: Thu, 10 May 2018 23:05:51 +0000 [thread overview]
Message-ID: <20180510230551.GE27853@wotan.suse.de> (raw)
In-Reply-To: <20180510204807.GV30522@ZenIV.linux.org.uk>
On Thu, May 10, 2018 at 09:48:07PM +0100, Al Viro wrote:
> On Thu, Apr 26, 2018 at 04:46:39PM -0700, Luis R. Rodriguez wrote:
>
> > Since we cannot set these attributes we should special-case the
> > immutable/append on delete for symlinks, this would be consistent with
> > what we *do* allow on Linux for all filesystems.
>
> Er... So why not simply sanity-check it in places that set it on
> inodes?
The patch is not about sanity-checks on setters though as *that* is in place
already. Its about the case where the filesystem gets corrupted and the VFS
*still* does process these attributes for symlinks and still prevents
deletion because of these attributes.
So we already do not allow for settings these attributes.
> If anything, I would suggest
> * converting all places that set those in ->i_flags to
> inode_set_flags()
> * making inode_set_flags() check and return an error on
> that...
But if I misunderstood your suggestion please let me know. I'll send out
a v2 RFC next which illustrates what filesystems can do for now.
Luis
next prev parent reply other threads:[~2018-05-10 23:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 23:46 [RFC] vfs: skip extra attributes check on removal for symlinks Luis R. Rodriguez
2018-05-01 17:23 ` Darrick J. Wong
2018-05-01 17:45 ` Luis R. Rodriguez
2018-05-08 0:30 ` Darrick J. Wong
2018-05-09 0:03 ` Luis R. Rodriguez
2018-05-09 0:17 ` Darrick J. Wong
2018-05-09 0:38 ` Luis R. Rodriguez
2018-05-09 1:39 ` Darrick J. Wong
2018-05-10 20:48 ` Al Viro
2018-05-10 23:05 ` Luis R. Rodriguez [this message]
2018-05-11 2:42 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180510230551.GE27853@wotan.suse.de \
--to=mcgrof@kernel.org \
--cc=darrick.wong@oracle.com \
--cc=dhowells@redhat.com \
--cc=fliu@suse.com \
--cc=jack@suse.cz \
--cc=jake.norris@suse.com \
--cc=jeffm@suse.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=nborisov@suse.com \
--cc=sandeen@sandeen.net \
--cc=tytso@mit.edu \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).