From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([198.137.202.133]:51120 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752024AbeENIl3 (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Mon, 14 May 2018 04:41:29 -0400
Date: Mon, 14 May 2018 01:41:28 -0700
From: Christoph Hellwig <hch@infradead.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org,
        "Darrick J . Wong" <darrick.wong@oracle.com>
Subject: Re: [PATCH 14/15] xfs_vn_lookup: simplify a bit
Message-ID: <20180514084128.GA3092@infradead.org>
References: <20180513212612.GV30522@ZenIV.linux.org.uk>
 <20180513213017.31269-1-viro@ZenIV.linux.org.uk>
 <20180513213017.31269-14-viro@ZenIV.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180513213017.31269-14-viro@ZenIV.linux.org.uk>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Sun, May 13, 2018 at 10:30:16PM +0100, Al Viro wrote:
> From: Al Viro <viro@zeniv.linux.org.uk>
> 
> have all post-xfs_lookup() branches converge on d_splice_alias()

I think this would be even better if you'd switch xfs_lookup so that it
returns a struct inode instead or ERR_PTR instead of an int and a
struct xfs_inode in the argument first.  That is what all callers want
anyway.