From: David Sterba <dsterba@suse.cz>
To: Mark Fasheh <mfasheh@suse.de>
Cc: linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] vfs: dedupe should return EPERM if permission is not granted
Date: Mon, 14 May 2018 16:58:20 +0200 [thread overview]
Message-ID: <20180514145820.GL6649@twin.jikos.cz> (raw)
In-Reply-To: <20180511192651.21324-3-mfasheh@suse.de>
On Fri, May 11, 2018 at 12:26:51PM -0700, Mark Fasheh wrote:
> Right now we return EINVAL if a process does not have permission to dedupe a
> file. This was an oversight on my part. EPERM gives a true description of
> the nature of our error, and EINVAL is already used for the case that the
> filesystem does not support dedupe.
>
> Signed-off-by: Mark Fasheh <mfasheh@suse.de>
Acked-by: David Sterba <dsterba@suse.com>
We've been using EINVAL when the request is invalid in the ioctls, eg.
combination of arguments that does not make sense, while EPERM is for
cases when the request is ok but there's still some permission missing,
> } else if (!(is_admin || (dst_file->f_mode & FMODE_WRITE) ||
> uid_eq(current_fsuid(), dst->i_uid))) {
> - info->status = -EINVAL;
> + info->status = -EPERM;
exactly like this.
next prev parent reply other threads:[~2018-05-14 15:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 19:26 [PATCH 0/2] vfs: better dedupe permission check Mark Fasheh
2018-05-11 19:26 ` [PATCH 1/2] vfs: allow dedupe of user owned read-only files Mark Fasheh
2018-05-11 23:58 ` Darrick J. Wong
2018-05-12 2:49 ` Adam Borowski
2018-05-13 18:16 ` Mark Fasheh
2018-05-13 20:50 ` Adam Borowski
2018-05-17 23:01 ` Mark Fasheh
2018-05-11 19:26 ` [PATCH 2/2] vfs: dedupe should return EPERM if permission is not granted Mark Fasheh
2018-05-12 0:06 ` Darrick J. Wong
2018-05-12 4:15 ` Amir Goldstein
2018-05-12 4:37 ` Duncan
2018-05-13 14:30 ` Adam Borowski
2018-05-13 18:21 ` Mark Fasheh
2018-05-13 18:26 ` Darrick J. Wong
2018-05-17 5:15 ` Zygo Blaxell
2018-05-17 23:03 ` Mark Fasheh
2018-05-14 14:58 ` David Sterba [this message]
2018-09-10 23:21 [PATCH v6 0/2] vfs: fix dedupe permission check Mark Fasheh
2018-09-10 23:21 ` [PATCH 2/2] vfs: dedupe should return EPERM if permission is not granted Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180514145820.GL6649@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mfasheh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).