From: "J. Bruce Fields" <bfields@fieldses.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Jeff Layton <jlayton@kernel.org>
Subject: Re: [RFC][PATCH] nfsd: vfs_mkdir() might succeed leaving dentry negative unhashed
Date: Mon, 14 May 2018 11:32:16 -0400 [thread overview]
Message-ID: <20180514153216.GC7160@fieldses.org> (raw)
In-Reply-To: <20180511211339.GG30522@ZenIV.linux.org.uk>
On Fri, May 11, 2018 at 10:13:39PM +0100, Al Viro wrote:
> [-stable fodder; as it is, one can e.g. add
> /mnt/cgroup localhost(rw,no_root_squash,fsid=4242)
> to /etc/exports,
> mount -t cgroup none /mnt/cgroup
> mkdir /tmp/a
> mount -t nfs localhost://mnt/cgroup /tmp/a
> mkdir /tmp/a/foo
How is the cgroup filesystem exportable? That sounds like a bug in
itself. We don't want people using NFS as some kind of weird remote
configuration protocol.
> and have knfsd oops; the patch below deals with that.
>
> Questions:
> 1) is fh_update() use below legitimate, or should we
> do fh_put/fh_compose instead?
fh_update looks OK to me, but do we need it here? There's already a
if (!err)
err = fh_update(reshp);
at the end of nfsd_create_locked.
> 2) is nfserr_serverfail valid for situation when
> directory created by such vfs_mkdir() manages to disappear
> under us immediately afterwards? Or should we return nfserr_stale
> instead?
We just got a successful result on the create and the parent's still
locked, so if somebody hits this I think we want them reporting a bug,
not wasting time trying to find a mistake in their own logic.
> It's in vfs.git#for-linus, if you prefer to use git for review...
> ]
>
> That can (and does, on some filesystems) happen - ->mkdir() (and thus
> vfs_mkdir()) can legitimately leave its argument negative and just
> unhash it, counting upon the lookup to pick the object we'd created
> next time we try to look at that name.
>
> Some vfs_mkdir() callers forget about that possibility...
I'd rather have this in a helper function with a comment or two, but I
can do that as a followup patch.
--b.
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> index 2410b093a2e6..b0555d7d8200 100644
> --- a/fs/nfsd/vfs.c
> +++ b/fs/nfsd/vfs.c
> @@ -1201,6 +1201,28 @@ nfsd_create_locked(struct svc_rqst *rqstp, struct svc_fh *fhp,
> break;
> case S_IFDIR:
> host_err = vfs_mkdir(dirp, dchild, iap->ia_mode);
> + if (!host_err && unlikely(d_unhashed(dchild))) {
> + struct dentry *d;
> + d = lookup_one_len(dchild->d_name.name,
> + dchild->d_parent,
> + dchild->d_name.len);
> + if (IS_ERR(d)) {
> + host_err = PTR_ERR(d);
> + break;
> + }
> + if (unlikely(d_is_negative(d))) {
> + dput(d);
> + err = nfserr_serverfault;
> + goto out;
> + }
> + dput(resfhp->fh_dentry);
> + resfhp->fh_dentry = dget(d);
> + err = fh_update(resfhp);
> + dput(dchild);
> + dchild = d;
> + if (err)
> + goto out;
> + }
> break;
> case S_IFCHR:
> case S_IFBLK:
next prev parent reply other threads:[~2018-05-14 15:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 21:13 [RFC][PATCH] nfsd: vfs_mkdir() might succeed leaving dentry negative unhashed Al Viro
2018-05-14 15:32 ` J. Bruce Fields [this message]
2018-05-14 15:45 ` Al Viro
2018-05-14 16:27 ` J. Bruce Fields
2018-05-14 17:00 ` Al Viro
2018-05-14 17:56 ` J. Bruce Fields
2018-05-14 16:47 ` Al Viro
2018-05-16 14:09 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180514153216.GC7160@fieldses.org \
--to=bfields@fieldses.org \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).