From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 15 May 2018 09:26:25 +0200 From: Christoph Hellwig To: Goldwyn Rodrigues Cc: Christoph Hellwig , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 31/33] iomap: add support for sub-pagesize buffered I/O without buffer heads Message-ID: <20180515072625.GA23384@lst.de> References: <20180509074830.16196-1-hch@lst.de> <20180509074830.16196-32-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: On Mon, May 14, 2018 at 11:00:08AM -0500, Goldwyn Rodrigues wrote: > > + if (iop || i_blocksize(inode) == PAGE_SIZE) > > + return iop; > > Why is this an equal comparison operator? Shouldn't this be >= to > include filesystem blocksize greater than PAGE_SIZE? Which filesystems would that be that have a tested and working PAGE_SIZE support using iomap?