From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:57458 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752129AbeEOJyA (ORCPT ); Tue, 15 May 2018 05:54:00 -0400 Date: Tue, 15 May 2018 10:53:51 +0100 From: Mark Rutland To: Dominik Brodowski Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, dave.martin@arm.com, james.morse@arm.com, linux-fsdevel@vger.kernel.org, marc.zyngier@arm.com, viro@zeniv.linux.org.uk, will.deacon@arm.com Subject: Re: [PATCH 13/18] kernel: add kcompat_sys_{f,}statfs64() Message-ID: <20180515095351.lw5gxap4ii5iobtb@lakrids.cambridge.arm.com> References: <20180514094640.27569-1-mark.rutland@arm.com> <20180514094640.27569-14-mark.rutland@arm.com> <20180514171427.qyietn3fhilwokb2@lakrids.cambridge.arm.com> <20180514203414.GB26773@light.dominikbrodowski.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180514203414.GB26773@light.dominikbrodowski.net> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, May 14, 2018 at 10:34:14PM +0200, Dominik Brodowski wrote: > On Mon, May 14, 2018 at 06:14:28PM +0100, Mark Rutland wrote: > > On Mon, May 14, 2018 at 10:46:35AM +0100, Mark Rutland wrote: > > > +#ifdef CONFIG_COMPAT > > > +int kcompat_sys_statfs64(const char __user * pathname, compat_size_t sz, > > > + struct compat_statfs64 __user * buf); > > > +int kcompat_sys_fstatfs64(unsigned int fd, compat_size_t sz, > > > + struct compat_statfs64 __user * buf); > > > +#endif > > > > I've moved these to , so that they live with the rest of > > the compat syscall stuff. That should avoid build failures the kbuild > > test robot picked up where compat_size_t wasn't dfined. > > Please add a comment there, similar to what is in syscalls.h: > > /* > * Kernel code should not call syscalls (i.e., sys_xyzyyz()) directly. > * Instead, use one of the functions which work equivalently, such as > * the ksys_xyzyyz() functions prototyped below. > */ To make the kcompat_sys_* naming scheme clearer, I've added compat references to the above, i.e. /* * Kernel code should not call compat syscalls (i.e., compat_sys_xyzyyz()) * directly. Instead, use one of the functions which work equivalently, such * as the kcompat_sys_xyzyyz() functions prototyped below. */ > Once you have done so, feel free to add my > > Reviewed-by: Dominik Brodowski I hope that this still stands with the changes above? Thanks, Mark.