archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH 2/3] proc: Add a way to make network proc files writable
@ 2018-05-15 19:08 Alexey Dobriyan
  0 siblings, 0 replies; only message in thread
From: Alexey Dobriyan @ 2018-05-15 19:08 UTC (permalink / raw)
  To: hch, dhowells; +Cc: linux-kernel, linux-fsdevel

Christoph Hellwig wrote:
> On Tue, May 01, 2018 at 12:20:33AM +0100, David Howells wrote:
> > Provide two extra functions, proc_create_net_data_write() and
> > proc_create_net_single_write() that act like their non-write versions but
> > also set a write method in the proc_dir_entry struct.
> > 
> > An internal simple write function is provided that will copy its buffer and
> > hand it to the pde->write() method if available (or give an error if not).
> > The buffer may be modified by the write method.
> I thought of doing something like this, aѕ it would remove tons of
> boilerplat code from a lot of procfs instances.  But I'd also like to
> hear what Al and Alexey think of it.  We also should offer this for
> non-net proc users as well.

For the record I hate both series. This is kmalloc disease with its
dozens of signatures to do the same thing slightly differently.
It is just runtime .text reduction is hard to argue against.

Function names become longer and signatures themselves become longer and
now you're arguing about indentation and character limit.

I remember reading about abusing C99 intializers to emulate optional
parameters somewhere. If it can be used (with bloat-o-meter in mind)
it will be very much appreciated.

Currently there are

	simple seq_file
	custom seq_file with start and stop
	optional write hook
	->data pointer

which is already way too much.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-05-15 19:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-15 19:08 [PATCH 2/3] proc: Add a way to make network proc files writable Alexey Dobriyan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).