linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Omar Sandoval <osandov@osandov.com>,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Jan Kara <jack@suse.cz>, Aleksei Besogonov <cyberax@amazon.com>
Subject: Re: [PATCH] iomap: don't allow holes in swapfiles
Date: Wed, 16 May 2018 08:56:38 -0700	[thread overview]
Message-ID: <20180516155638.GD23858@magnolia> (raw)
In-Reply-To: <20180516155146.GA8294@infradead.org>

On Wed, May 16, 2018 at 08:51:46AM -0700, Christoph Hellwig wrote:
> On Wed, May 16, 2018 at 08:50:00AM -0700, Darrick J. Wong wrote:
> > > Hey, Darrick, I noticed this while writing up a generic xfstest to test
> > > that the Btrfs swap support patches don't allow a swapfile with holes.
> > > It'd be nice if we were all consistent :) This is based on
> > > xfs-linux/for-next. Feel free to fold it in to your patch or apply it
> > > separately as you see fit. Thanks!
> > 
> > I sent a testcase of my own ("generic: test swapfile creation,
> > activation, and deactivation") a while back; would you mind sending out
> > yours so we can combine them into a single testcase?
> 
> Wasn't the desire to support holes the rationale for the Aleksei
> version of the iomap swapfile patch?

Ah, so it was.  FWIW I'm not sure why you'd /want/ a holey swapfile?

TBH my motivation for iomap swapfile is purely to remove bmap callers. :)

--D

> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-05-16 15:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-16  6:45 Omar Sandoval
2018-05-16 15:50 ` Darrick J. Wong
2018-05-16 15:51   ` Christoph Hellwig
2018-05-16 15:56     ` Darrick J. Wong [this message]
2018-05-16 16:19       ` Omar Sandoval
2018-05-16 16:24         ` Christoph Hellwig
2018-05-16 16:23 ` Christoph Hellwig
2018-05-16 16:26   ` Omar Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180516155638.GD23858@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=cyberax@amazon.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=osandov@osandov.com \
    --subject='Re: [PATCH] iomap: don'\''t allow holes in swapfiles' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).