From: Christoph Hellwig <hch@infradead.org>
To: Omar Sandoval <osandov@osandov.com>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
Christoph Hellwig <hch@infradead.org>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Jan Kara <jack@suse.cz>, Aleksei Besogonov <cyberax@amazon.com>
Subject: Re: [PATCH] iomap: don't allow holes in swapfiles
Date: Wed, 16 May 2018 09:24:15 -0700 [thread overview]
Message-ID: <20180516162415.GB21071@infradead.org> (raw)
In-Reply-To: <20180516161955.GA14174@vader>
On Wed, May 16, 2018 at 09:19:55AM -0700, Omar Sandoval wrote:
> > > Wasn't the desire to support holes the rationale for the Aleksei
> > > version of the iomap swapfile patch?
> >
> > Ah, so it was. FWIW I'm not sure why you'd /want/ a holey swapfile?
>
> >From reading the old thread, it looks like Aleksei just wanted
> fallocated swap files to work: "I've traced the problem to bmap(), used
> in generic_swapfile_activate call, which returns 0 for blocks inside
> holes created by fallocate".
Oh, that makes more sense.
> Are holes in that sense are different from
> actual holes in the iomap sense?
Unwritten extents aren't actually holes in any sense, so they are
very different and should work with the iomap swapfile code.
next prev parent reply other threads:[~2018-05-16 16:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 6:45 Omar Sandoval
2018-05-16 15:50 ` Darrick J. Wong
2018-05-16 15:51 ` Christoph Hellwig
2018-05-16 15:56 ` Darrick J. Wong
2018-05-16 16:19 ` Omar Sandoval
2018-05-16 16:24 ` Christoph Hellwig [this message]
2018-05-16 16:23 ` Christoph Hellwig
2018-05-16 16:26 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180516162415.GB21071@infradead.org \
--to=hch@infradead.org \
--cc=cyberax@amazon.com \
--cc=darrick.wong@oracle.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=osandov@osandov.com \
--subject='Re: [PATCH] iomap: don'\''t allow holes in swapfiles' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).