From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Omar Sandoval <osandov@osandov.com>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Jan Kara <jack@suse.cz>, Aleksei Besogonov <cyberax@amazon.com>,
kernel-team@fb.com
Subject: Re: [PATCH v2 1/2] iomap: provide more useful errors for invalid swap files
Date: Wed, 16 May 2018 11:22:22 -0700 [thread overview]
Message-ID: <20180516182222.GA21917@infradead.org> (raw)
In-Reply-To: <20180516181142.GK23858@magnolia>
On Wed, May 16, 2018 at 11:11:42AM -0700, Darrick J. Wong wrote:
> That's what I thought -- we only see NULL_ADDR for holes and delalloc
> extents, and we already check for both of those. But I didn't see
> anything in iomap.h expressly saying that, so I decided to be defensive
> and check it anyway.
>
> IOWs it would be helpful to have a little more documentation about which
> flags go together,
patches welcome :)
> particularly for things like IOMAP_F_BOUNDARY that
> don't have any meaning in xfs.
Yikes, how did that even end in the tree? That whole boundary
thing already made little sene on buffer heads, and even less
so in the generic iomap code. I think we just need to allocate
a few flags for fs specific uses and move it into gfs2.
next prev parent reply other threads:[~2018-05-16 18:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 16:45 [PATCH v2 0/2] iomap: swapfile tweaks Omar Sandoval
2018-05-16 16:45 ` [PATCH v2 1/2] iomap: provide more useful errors for invalid swap files Omar Sandoval
2018-05-16 16:54 ` Darrick J. Wong
2018-05-16 17:25 ` Christoph Hellwig
2018-05-16 17:32 ` Omar Sandoval
2018-05-16 17:46 ` Christoph Hellwig
2018-05-16 18:11 ` Darrick J. Wong
2018-05-16 18:22 ` Christoph Hellwig [this message]
2018-05-16 16:45 ` [PATCH v2 2/2] iomap: don't allow holes in swapfiles Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180516182222.GA21917@infradead.org \
--to=hch@infradead.org \
--cc=cyberax@amazon.com \
--cc=darrick.wong@oracle.com \
--cc=jack@suse.cz \
--cc=kernel-team@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).