From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
viro@ZenIV.linux.org.uk, willy@infradead.org, andres@anarazel.de
Subject: Re: [RFC PATCH 01/11] vfs: push __sync_blockdev calls down into sync_fs routines
Date: Fri, 18 May 2018 08:56:36 -0700 [thread overview]
Message-ID: <20180518155636.GB16931@infradead.org> (raw)
In-Reply-To: <20180518123415.28181-2-jlayton@kernel.org>
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1097,7 +1097,7 @@ xfs_fs_sync_fs(
> * Doing anything during the async pass would be counterproductive.
> */
> if (!wait)
> - return 0;
> + goto out;
>
> xfs_log_force(mp, XFS_LOG_SYNC);
> if (laptop_mode) {
> @@ -1108,8 +1108,8 @@ xfs_fs_sync_fs(
> */
> flush_delayed_work(&mp->m_log->l_work);
> }
> -
> - return 0;
> +out:
> + return __sync_blockdev(sb->s_bdev, wait);
XFS never uses the block device mapping for anything, so this is
not needed.
> +/*
> + * Many legacy filesystems don't have a sync_fs op. For them, we just flush
> + * the block device (if there is one).
> + */
> +static inline int call_sync_fs(struct super_block *sb, int wait)
> +{
> + if (sb->s_op->sync_fs)
> + return sb->s_op->sync_fs(sb, wait);
> + return __sync_blockdev(sb->s_bdev, wait);
> +}
The proper name for this would be vfs_sync_fs. And I don't think it
warrants an inline.
next prev parent reply other threads:[~2018-05-18 15:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 12:34 [RFC PATCH 00/11] vfs: have syncfs return an error when inode writeback fails Jeff Layton
2018-05-18 12:34 ` [RFC PATCH 01/11] vfs: push __sync_blockdev calls down into sync_fs routines Jeff Layton
2018-05-18 15:56 ` Christoph Hellwig [this message]
2018-05-18 17:56 ` Jeff Layton
2018-05-18 12:34 ` [RFC PATCH 02/11] vfs: add a new errseq_t pointer to sync_fs prototype Jeff Layton
2018-05-18 12:34 ` [RFC PATCH 03/11] vfs: add an errseq_t pointer to sync_filesystem Jeff Layton
2018-05-18 12:34 ` [RFC PATCH 04/11] vfs: add errseq_t pointer to __sync_filesystem Jeff Layton
2018-05-18 12:34 ` [RFC PATCH 05/11] fs: track per-sb writeback errors and report them to syncfs Jeff Layton
2018-05-18 12:34 ` [RFC PATCH 06/11] buffer: record blockdev write errors in super_block that backs them Jeff Layton
2018-05-18 12:34 ` [RFC PATCH 07/11] ext4: have sync_fs op report writeback errors when passed a since pointer Jeff Layton
2018-05-18 15:22 ` Matthew Wilcox
2018-05-18 16:50 ` Jeff Layton
2018-05-18 12:34 ` [RFC PATCH 08/11] xfs: " Jeff Layton
2018-05-21 23:01 ` Dave Chinner
2018-05-21 23:23 ` Jeff Layton
2018-05-18 12:34 ` [RFC PATCH 09/11] btrfs: " Jeff Layton
2018-05-18 12:34 ` [RFC PATCH 10/11] ext2: " Jeff Layton
2018-05-18 12:34 ` [RFC PATCH 11/11] vfs: have call_sync_fs " Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518155636.GB16931@infradead.org \
--to=hch@infradead.org \
--cc=andres@anarazel.de \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).