From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:59594 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752230AbeERQBd (ORCPT ); Fri, 18 May 2018 12:01:33 -0400 Date: Fri, 18 May 2018 09:01:32 -0700 From: Christoph Hellwig To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Dave Chinner , darrick.wong@oracle.com, tytso@mit.edu, linux-btrfs@vger.kernel.org, clm@fb.com, jbacik@fb.com, viro@zeniv.linux.org.uk, willy@infradead.org, peterz@infradead.org Subject: Re: [PATCH 05/10] don't use spin_lock_irqsave() unnecessarily Message-ID: <20180518160132.GB22791@infradead.org> References: <20180518074918.13816-1-kent.overstreet@gmail.com> <20180518074918.13816-11-kent.overstreet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180518074918.13816-11-kent.overstreet@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, May 18, 2018 at 03:49:08AM -0400, Kent Overstreet wrote: > Signed-off-by: Kent Overstreet Looks generally fine. A little changelog with an explanation of how we obviously never could get here with irqs disabled would be nice, though.