archive mirror
 help / color / mirror / Atom feed
From: David Sterba <>
To: Al Viro <>
Subject: Re: [RFC][PATCH] affs_lookup(): close a race with affs_remove_link()
Date: Mon, 21 May 2018 15:29:28 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Sun, May 13, 2018 at 05:00:40PM +0100, Al Viro wrote:
> [#fixes unless somebody yells; -stable fodder and yes, it _is_ that old -
> all way back to 2001]
> we unlock the directory hash too early - if we are looking at secondary
> link and primary (in another directory) gets removed just as we unlock,
> we could have the old primary moved in place of the secondary, leaving
> us to look into freed entry (and leaving our dentry with ->d_fsdata
> pointing to a freed entry).
> Cc: # 2.4.4+
> Signed-off-by: Al Viro <>

Sorry for the delay. As far as my limited knowledge of the AFFS code
goes, this change looks ok. You can add my

Acked-by: David Sterba <>

and please take it through the vfs tree. Thanks.

      reply	other threads:[~2018-05-21 13:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-13 16:00 [RFC][PATCH] affs_lookup(): close a race with affs_remove_link() Al Viro
2018-05-21 13:29 ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).