From: David Sterba <dsterba@suse.cz>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [RFC][PATCH] affs_lookup(): close a race with affs_remove_link()
Date: Mon, 21 May 2018 15:29:28 +0200 [thread overview]
Message-ID: <20180521132928.GV6649@suse.cz> (raw)
In-Reply-To: <20180513160040.GM30522@ZenIV.linux.org.uk>
On Sun, May 13, 2018 at 05:00:40PM +0100, Al Viro wrote:
> [#fixes unless somebody yells; -stable fodder and yes, it _is_ that old -
> all way back to 2001]
>
> we unlock the directory hash too early - if we are looking at secondary
> link and primary (in another directory) gets removed just as we unlock,
> we could have the old primary moved in place of the secondary, leaving
> us to look into freed entry (and leaving our dentry with ->d_fsdata
> pointing to a freed entry).
>
> Cc: stable@vger.kernel.org # 2.4.4+
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Sorry for the delay. As far as my limited knowledge of the AFFS code
goes, this change looks ok. You can add my
Acked-by: David Sterba <dsterba@suse.com>
and please take it through the vfs tree. Thanks.
prev parent reply other threads:[~2018-05-21 13:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-13 16:00 [RFC][PATCH] affs_lookup(): close a race with affs_remove_link() Al Viro
2018-05-21 13:29 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180521132928.GV6649@suse.cz \
--to=dsterba@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).