From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:59351 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751609AbeEUNcL (ORCPT ); Mon, 21 May 2018 09:32:11 -0400 Date: Mon, 21 May 2018 15:29:28 +0200 From: David Sterba To: Al Viro Cc: linux-fsdevel@vger.kernel.org Subject: Re: [RFC][PATCH] affs_lookup(): close a race with affs_remove_link() Message-ID: <20180521132928.GV6649@suse.cz> Reply-To: dsterba@suse.cz References: <20180513160040.GM30522@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180513160040.GM30522@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, May 13, 2018 at 05:00:40PM +0100, Al Viro wrote: > [#fixes unless somebody yells; -stable fodder and yes, it _is_ that old - > all way back to 2001] > > we unlock the directory hash too early - if we are looking at secondary > link and primary (in another directory) gets removed just as we unlock, > we could have the old primary moved in place of the secondary, leaving > us to look into freed entry (and leaving our dentry with ->d_fsdata > pointing to a freed entry). > > Cc: stable@vger.kernel.org # 2.4.4+ > Signed-off-by: Al Viro Sorry for the delay. As far as my limited knowledge of the AFFS code goes, this change looks ok. You can add my Acked-by: David Sterba and please take it through the vfs tree. Thanks.