linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, Fabian Frederick <fabf@skynet.be>
Subject: Re: [RFC][PATCH] affs_lookup: switch to d_splice_alias()
Date: Mon, 21 May 2018 15:46:09 +0200	[thread overview]
Message-ID: <20180521134609.GW6649@suse.cz> (raw)
In-Reply-To: <20180513160341.GN30522@ZenIV.linux.org.uk>

On Sun, May 13, 2018 at 05:03:42PM +0100, Al Viro wrote:
> Making something exportable takes more than providing ->s_export_ops.
> In particular, ->lookup() *MUST* use d_splice_alias() instead of
> d_add().
> 
> Reading Documentation/filesystems/nfs/Exporting would've been a good idea;
> as it is, exporting AFFS is badly (and exploitably) broken.
> 
> Partially-Fixes: ed4433d72394 "fs/affs: make affs exportable"
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Acked-by: David Sterba <dsterba@suse.com>

  reply	other threads:[~2018-05-21 13:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-13 16:03 [RFC][PATCH] affs_lookup: switch to d_splice_alias() Al Viro
2018-05-21 13:46 ` David Sterba [this message]
2018-10-29 16:45 ` Fabian Frederick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180521134609.GW6649@suse.cz \
    --to=dsterba@suse.cz \
    --cc=fabf@skynet.be \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).