From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx2.suse.de ([195.135.220.15]:60108 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751145AbeEUNsw (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Mon, 21 May 2018 09:48:52 -0400
Date: Mon, 21 May 2018 15:46:09 +0200
From: David Sterba <dsterba@suse.cz>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, Fabian Frederick <fabf@skynet.be>
Subject: Re: [RFC][PATCH] affs_lookup: switch to d_splice_alias()
Message-ID: <20180521134609.GW6649@suse.cz>
Reply-To: dsterba@suse.cz
References: <20180513160341.GN30522@ZenIV.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180513160341.GN30522@ZenIV.linux.org.uk>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Sun, May 13, 2018 at 05:03:42PM +0100, Al Viro wrote:
> Making something exportable takes more than providing ->s_export_ops.
> In particular, ->lookup() *MUST* use d_splice_alias() instead of
> d_add().
> 
> Reading Documentation/filesystems/nfs/Exporting would've been a good idea;
> as it is, exporting AFFS is badly (and exploitably) broken.
> 
> Partially-Fixes: ed4433d72394 "fs/affs: make affs exportable"
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Acked-by: David Sterba <dsterba@suse.com>