linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [RFC][PATCH] ext2: fix a block leak
Date: Wed, 23 May 2018 16:24:46 +0200	[thread overview]
Message-ID: <20180523142446.lok5uvdl5mcna43c@quack2.suse.cz> (raw)
In-Reply-To: <20180523115824.764m62stzn33r4xj@quack2.suse.cz>

On Wed 23-05-18 13:58:24, Jan Kara wrote:
> On Fri 18-05-18 01:06:25, Al Viro wrote:
> > open file, unlink it, then use ioctl(2) to make it immutable or
> > append only.  Now close it and watch the blocks *not* freed...
> > 
> > Immutable/append-only checks belong in ->setattr().
> > Note: the bug is old and backport to anything prior to 737f2e93b972
> > ("ext2: convert to use the new truncate convention") will need
> > these checks lifted into ext2_setattr().
> > 
> > Cc: stable@kernel.org
> > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> 
> Sorry, I've been busy with other stuff after LSF/MM and then forgot about
> this. Thanks for the patch! I've added the patch to my tree.

Bah, and now I see (thanks Amir for the notice) you've already pushed it to
Linus. Sorry for the noise.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

      reply	other threads:[~2018-05-23 14:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18  0:06 Al Viro
2018-05-23 11:58 ` Jan Kara
2018-05-23 14:24   ` Jan Kara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180523142446.lok5uvdl5mcna43c@quack2.suse.cz \
    --to=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    --subject='Re: [RFC][PATCH] ext2: fix a block leak' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).