From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from youngberry.canonical.com ([91.189.89.112]:48535 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964823AbeEXM6g (ORCPT ); Thu, 24 May 2018 08:58:36 -0400 Received: from mail-io0-f199.google.com ([209.85.223.199]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1fLppD-0003OO-4b for linux-fsdevel@vger.kernel.org; Thu, 24 May 2018 12:58:35 +0000 Received: by mail-io0-f199.google.com with SMTP id i1-v6so1494088ioh.15 for ; Thu, 24 May 2018 05:58:35 -0700 (PDT) Date: Thu, 24 May 2018 07:58:32 -0500 From: Seth Forshee To: "Eric W. Biederman" Cc: Linux Containers , linux-fsdevel@vger.kernel.org, "Serge E. Hallyn" , Christian Brauner , linux-kernel@vger.kernel.org Subject: Re: [REVIEW][PATCH 1/6] vfs: Don't allow changing the link count of an inode with an invalid uid or gid Message-ID: <20180524125832.GP3401@ubuntu-xps13> References: <87o9h6554f.fsf@xmission.com> <20180523232538.4880-1-ebiederm@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180523232538.4880-1-ebiederm@xmission.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, May 23, 2018 at 06:25:33PM -0500, Eric W. Biederman wrote: > Changing the link count of an inode via unlink or link will cause a > write back of that inode. If the uids or gids are invalid (aka not known > to the kernel) writing the inode back may change the uid or gid in the > filesystem. To prevent possible filesystem and to avoid the need for > filesystem maintainers to worry about it don't allow operations on > inodes with an invalid uid or gid. > > Signed-off-by: "Eric W. Biederman" Acked-by: Seth Forshee