From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.mailbox.org ([80.241.60.215]:38824 "EHLO mx2.mailbox.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965999AbeEXR2e (ORCPT ); Thu, 24 May 2018 13:28:34 -0400 Date: Thu, 24 May 2018 19:28:21 +0200 From: Christian Brauner To: "Eric W. Biederman" Cc: Linux Containers , linux-kernel@vger.kernel.org, Seth Forshee , linux-fsdevel@vger.kernel.org Subject: Re: [REVIEW][PATCH 4/6] fs: Allow superblock owner to access do_remount_sb() Message-ID: <20180524172821.GA27641@mailbox.org> References: <87o9h6554f.fsf@xmission.com> <20180523232538.4880-4-ebiederm@xmission.com> <20180524155803.GB19932@mailbox.org> <87603d3svh.fsf@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87603d3svh.fsf@xmission.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, May 24, 2018 at 11:45:06AM -0500, Eric W. Biederman wrote: > Christian Brauner writes: > > > On Wed, May 23, 2018 at 06:25:36PM -0500, Eric W. Biederman wrote: > >> Superblock level remounts are currently restricted to global > >> CAP_SYS_ADMIN, as is the path for changing the root mount to > >> read only on umount. Loosen both of these permission checks to > >> also allow CAP_SYS_ADMIN in any namespace which is privileged > >> towards the userns which originally mounted the filesystem. > > > > Acked-by: Christian Brauner > > > >> > >> Signed-off-by: Seth Forshee > >> Acked-by: "Eric W. Biederman" > >> Acked-by: Serge Hallyn > > > > Note, I just talked to Serge. This should be Acked-by: Serge Hallyn > > Now you know how long these patches have been sitting waiting to get > merged. Indeed. :) Christian