From: Christian Brauner <christian@brauner.io> To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: torvalds@linux-foundation.org, tglx@linutronix.de, kstewart@linuxfoundation.org, gregkh@linuxfoundation.org, pombredanne@nexb.com, linux-api@vger.kernel.org, ebiederm@xmission.com, seth.forshee@canonical.com, viro@zeniv.linux.org.uk, Christian Brauner <christian@brauner.io> Subject: [PATCH 2/6 v1 resend] statfs: use << to align with fs header Date: Fri, 25 May 2018 14:48:21 +0200 [thread overview] Message-ID: <20180525124825.23875-3-christian@brauner.io> (raw) In-Reply-To: <20180525124825.23875-1-christian@brauner.io> After switching to using bit-shifts to define MS_* flags switch over ST_* flags too. ST_* and MS_* flags generally have the exact same value. Initializing them identically let's userspace easily detect when flags indicate the same property but use a different value in doing so. Signed-off-by: Christian Brauner <christian@brauner.io> --- v0->v1: * non-functional changes: extend commit message --- include/linux/statfs.h | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/include/linux/statfs.h b/include/linux/statfs.h index 3142e98546ac..b336c04e793c 100644 --- a/include/linux/statfs.h +++ b/include/linux/statfs.h @@ -27,18 +27,18 @@ struct kstatfs { * ABI. The exception is ST_VALID which has the same value as MS_REMOUNT * which doesn't make any sense for statfs. */ -#define ST_RDONLY 0x0001 /* mount read-only */ -#define ST_NOSUID 0x0002 /* ignore suid and sgid bits */ -#define ST_NODEV 0x0004 /* disallow access to device special files */ -#define ST_NOEXEC 0x0008 /* disallow program execution */ -#define ST_SYNCHRONOUS 0x0010 /* writes are synced at once */ -#define ST_VALID 0x0020 /* f_flags support is implemented */ -#define ST_MANDLOCK 0x0040 /* allow mandatory locks on an FS */ -/* 0x0080 used for ST_WRITE in glibc */ -/* 0x0100 used for ST_APPEND in glibc */ -/* 0x0200 used for ST_IMMUTABLE in glibc */ -#define ST_NOATIME 0x0400 /* do not update access times */ -#define ST_NODIRATIME 0x0800 /* do not update directory access times */ -#define ST_RELATIME 0x1000 /* update atime relative to mtime/ctime */ +#define ST_RDONLY (1<<0) /* mount read-only */ +#define ST_NOSUID (1<<1) /* ignore suid and sgid bits */ +#define ST_NODEV (1<<2) /* disallow access to device special files */ +#define ST_NOEXEC (1<<3) /* disallow program execution */ +#define ST_SYNCHRONOUS (1<<4) /* writes are synced at once */ +#define ST_VALID (1<<5) /* f_flags support is implemented */ +#define ST_MANDLOCK (1<<6) /* allow mandatory locks on an FS */ +/* (1<<7) used for ST_WRITE in glibc */ +/* (1<<8) used for ST_APPEND in glibc */ +/* (1<<9) used for ST_IMMUTABLE in glibc */ +#define ST_NOATIME (1<<10) /* do not update access times */ +#define ST_NODIRATIME (1<<11) /* do not update directory access times */ +#define ST_RELATIME (1<<12) /* update atime relative to mtime/ctime */ #endif -- 2.17.0
next prev parent reply other threads:[~2018-05-25 12:49 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-25 12:48 [PATCH 0/6 v1 resend] statfs: handle mount propagation Christian Brauner 2018-05-25 12:48 ` [PATCH 1/6 v1 resend] fs: use << for MS_* flags Christian Brauner 2018-05-25 12:48 ` Christian Brauner [this message] 2018-05-25 12:48 ` [PATCH 3/6 v1 resend] statfs: add ST_UNBINDABLE Christian Brauner 2018-05-25 12:48 ` [PATCH 4/6 v1 resend] statfs: add ST_SHARED Christian Brauner 2018-05-25 12:48 ` [PATCH 5/6 v1 resend] statfs: add ST_SLAVE Christian Brauner 2018-05-25 12:48 ` [PATCH 6/6 v1 resend] statfs: add ST_PRIVATE Christian Brauner 2018-06-13 14:06 ` [PATCH 0/6 v1 resend] statfs: handle mount propagation Christian Brauner 2018-06-13 14:24 ` Greg KH 2018-06-13 15:07 ` Christian Brauner 2018-07-19 15:30 ` Christian Brauner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180525124825.23875-3-christian@brauner.io \ --to=christian@brauner.io \ --cc=ebiederm@xmission.com \ --cc=gregkh@linuxfoundation.org \ --cc=kstewart@linuxfoundation.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pombredanne@nexb.com \ --cc=seth.forshee@canonical.com \ --cc=tglx@linutronix.de \ --cc=torvalds@linux-foundation.org \ --cc=viro@zeniv.linux.org.uk \ --subject='Re: [PATCH 2/6 v1 resend] statfs: use << to align with fs header' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).