From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Toshi Kani <toshi.kani@hpe.com>,
Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvdimm@lists.01.org,
Ross Zwisler <ross.zwisler@linux.intel.com>,
linux-xfs@vger.kernel.org
Subject: [PATCH resend 6/7] dm-snap: remove unnecessary direct_access() stub
Date: Fri, 25 May 2018 16:00:54 -0600 [thread overview]
Message-ID: <20180525220055.18920-7-ross.zwisler@linux.intel.com> (raw)
In-Reply-To: <20180525220055.18920-1-ross.zwisler@linux.intel.com>
This stub was added so that we could use dm-snap with DM_TYPE_DAX_BIO_BASED
mode devices. That mode and the transition issues associated with it no
longer exist, so we can remove this dead code.
Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
---
drivers/md/dm-snap.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/md/dm-snap.c b/drivers/md/dm-snap.c
index 216035be5661..0143b158d52d 100644
--- a/drivers/md/dm-snap.c
+++ b/drivers/md/dm-snap.c
@@ -2305,13 +2305,6 @@ static int origin_map(struct dm_target *ti, struct bio *bio)
return do_origin(o->dev, bio);
}
-static long origin_dax_direct_access(struct dm_target *ti, pgoff_t pgoff,
- long nr_pages, void **kaddr, pfn_t *pfn)
-{
- DMWARN("device does not support dax.");
- return -EIO;
-}
-
/*
* Set the target "max_io_len" field to the minimum of all the snapshots'
* chunk sizes.
@@ -2371,7 +2364,6 @@ static struct target_type origin_target = {
.postsuspend = origin_postsuspend,
.status = origin_status,
.iterate_devices = origin_iterate_devices,
- .direct_access = origin_dax_direct_access,
};
static struct target_type snapshot_target = {
--
2.14.3
next prev parent reply other threads:[~2018-05-25 22:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 22:00 [PATCH resend 0/7] Fix DM DAX handling Ross Zwisler
2018-05-25 22:00 ` [PATCH resend 1/7] fs: allow per-device dax status checking for filesystems Ross Zwisler
2018-05-25 22:32 ` Eric Sandeen
2018-05-25 22:00 ` [PATCH resend 2/7] dax: change bdev_dax_supported() to support boolean returns Ross Zwisler
2018-05-25 22:00 ` [PATCH resend 3/7] dm: fix test for DAX device support Ross Zwisler
2018-05-25 22:00 ` [PATCH resend 4/7] dm: prevent DAX mounts if not supported Ross Zwisler
2018-05-25 22:00 ` [PATCH resend 5/7] dm: remove DM_TYPE_DAX_BIO_BASED dm_queue_mode Ross Zwisler
2018-05-25 22:00 ` Ross Zwisler [this message]
2018-05-25 22:00 ` [PATCH resend 7/7] dm-error: remove unnecessary direct_access() stub Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180525220055.18920-7-ross.zwisler@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=dm-devel@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=snitzer@redhat.com \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).