From: Michal Hocko <mhocko@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Mike Rapoport <rppt@linux.vnet.ibm.com>,
Dave Chinner <david@fromorbit.com>,
Jonathan Corbet <corbet@lwn.net>,
LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
"Darrick J. Wong" <darrick.wong@oracle.com>,
David Sterba <dsterba@suse.cz>
Subject: Re: [PATCH] doc: document scope NOFS, NOIO APIs
Date: Tue, 29 May 2018 10:21:30 +0200 [thread overview]
Message-ID: <20180529082130.GO27180@dhcp22.suse.cz> (raw)
In-Reply-To: <d2f6c4c1-856a-d233-8610-67a868b856f9@infradead.org>
On Mon 28-05-18 09:10:43, Randy Dunlap wrote:
> On 05/28/2018 02:21 AM, Michal Hocko wrote:
[...]
> > +reclaim context or when a transaction context nesting would be possible
> > +via reclaim. The corresponding restore function when the critical
>
> "The corresponding restore ... ends." << That is not a complete sentence.
> It's missing something.
Dave has pointed that out.
"The restore function should be called when the critical section ends."
> > +section ends. All that ideally along with an explanation what is
> > +the reclaim context for easier maintenance.
> > +
> > +Please note that the proper pairing of save/restore function allows
> > +nesting so it is safe to call ``memalloc_noio_save`` respectively
> > +``memalloc_noio_restore`` from an existing NOIO or NOFS scope.
>
> Please note that the proper pairing of save/restore functions allows
> nesting so it is safe to call ``memalloc_noio_save`` or
> ``memalloc_noio_restore`` respectively from an existing NOIO or NOFS scope.
Fixed. Thanks
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-05-29 8:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180424183536.GF30619@thunk.org>
2018-05-24 11:43 ` [PATCH] doc: document scope NOFS, NOIO APIs Michal Hocko
2018-05-24 14:33 ` Shakeel Butt
2018-05-24 14:47 ` Michal Hocko
2018-05-24 16:37 ` Randy Dunlap
2018-05-25 7:52 ` Michal Hocko
2018-05-28 7:21 ` Nikolay Borisov
2018-05-29 8:22 ` Michal Hocko
2018-05-28 11:32 ` Vlastimil Babka
2018-05-24 20:52 ` Jonathan Corbet
2018-05-25 8:11 ` Michal Hocko
2018-05-24 22:17 ` Dave Chinner
2018-05-24 23:25 ` Theodore Y. Ts'o
2018-05-25 8:16 ` Michal Hocko
2018-05-27 12:47 ` Mike Rapoport
2018-05-28 9:21 ` Michal Hocko
2018-05-28 16:10 ` Randy Dunlap
2018-05-29 8:21 ` Michal Hocko [this message]
2018-05-27 23:48 ` Dave Chinner
2018-05-28 9:19 ` Michal Hocko
2018-05-28 22:32 ` Dave Chinner
2018-05-29 8:18 ` Michal Hocko
2018-05-29 8:26 ` [PATCH v2] " Michal Hocko
2018-05-29 10:22 ` Dave Chinner
2018-05-29 11:50 ` Mike Rapoport
2018-05-29 11:51 ` Jonathan Corbet
2018-05-29 12:37 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529082130.GO27180@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=corbet@lwn.net \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=dsterba@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rdunlap@infradead.org \
--cc=rppt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).