From: Mike Snitzer <snitzer@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Mikulas Patocka <mpatocka@redhat.com>,
Shaohua Li <shli@kernel.org>, Alasdair Kergon <agk@redhat.com>,
device-mapper development <dm-devel@redhat.com>,
Matthew Wilcox <mawilcox@microsoft.com>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Heinz Mauelshagen <heinzm@redhat.com>,
linux-raid <linux-raid@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: dm: writecache: add DAX dependency
Date: Tue, 29 May 2018 09:06:01 -0400 [thread overview]
Message-ID: <20180529130601.GA31628@redhat.com> (raw)
In-Reply-To: <CAPcyv4gpMhBaUdy=UY9M0-2QomycGZCo+K6o+Dzjdc4jmPjrkg@mail.gmail.com>
On Mon, May 28 2018 at 2:18pm -0400,
Dan Williams <dan.j.williams@intel.com> wrote:
> On Mon, May 28, 2018 at 8:38 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > The new dm-writecache driver inconditionally uses the dax
> > subsystem, leading to link errors in some configurations:
> >
> > drivers/md/dm-writecache.o: In function `writecache_ctr':
> > dm-writecache.c:(.text+0x1fdc): undefined reference to `dax_read_lock'
> > dm-writecache.c:(.text+0x2004): undefined reference to `dax_direct_access'
> > dm-writecache.c:(.text+0x21cc): undefined reference to `dax_read_unlock'
> >
> > It seems wrong to require DAX in order to build the writecache
> > driver, but that at least avoids randconfig build errors.
> >
> > Fixes: bb15b431d650 ("dm: add writecache target")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > drivers/md/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
> > index 852c7ebe2902..f8ecf2da1edf 100644
> > --- a/drivers/md/Kconfig
> > +++ b/drivers/md/Kconfig
> > @@ -338,6 +338,7 @@ config DM_CACHE_SMQ
> > config DM_WRITECACHE
> > tristate "Writecache target"
> > depends on BLK_DEV_DM
> > + depends on DAX
>
> This should probably be depends on DAX && DAX_DRIVER as we at least
> need pmem or dcssblk enabled to provide a dax capable block device for
> DM to claim.
But dm-writecache is meant to be used for normal SSD even if PMEM isn't
available in the kernel.
next prev parent reply other threads:[~2018-05-29 13:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 15:38 [PATCH] dm: writecache: add DAX dependency Arnd Bergmann
2018-05-28 18:18 ` Dan Williams
2018-05-29 13:06 ` Mike Snitzer [this message]
2018-05-29 15:17 ` Ross Zwisler
2018-05-29 17:52 ` [PATCH] dm-writecache: fix compilation issue with !DAX Ross Zwisler
2018-05-29 18:08 ` Mike Snitzer
2018-05-29 18:40 ` Dan Williams
2018-05-29 19:57 ` Mike Snitzer
2018-05-30 12:22 ` [PATCH] " Mikulas Patocka
2018-05-30 13:13 ` Mike Snitzer
2018-05-30 12:21 ` [PATCH] dm: writecache: add DAX dependency Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529130601.GA31628@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=dm-devel@redhat.com \
--cc=heinzm@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=mawilcox@microsoft.com \
--cc=mpatocka@redhat.com \
--cc=ross.zwisler@linux.intel.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).