From: Matthew Wilcox <willy@infradead.org>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: viro@zeniv.linux.org.uk, hughd@google.com,
akpm@linux-foundation.org, mhocko@suse.com,
ross.zwisler@linux.intel.com, zi.yan@cs.rutgers.edu,
kirill.shutemov@linux.intel.com, dan.j.williams@intel.com,
gregkh@linuxfoundation.org, mark.rutland@arm.com,
riel@redhat.com, pasha.tatashin@oracle.com, jschoenh@amazon.de,
kstewart@linuxfoundation.org, rientjes@google.com,
tglx@linutronix.de, peterz@infradead.org, mgorman@suse.de,
yang.s@alibaba-inc.com, minchan@kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] mm: Change return type to vm_fault_t
Date: Tue, 29 May 2018 07:50:55 -0700 [thread overview]
Message-ID: <20180529145055.GA15148@bombadil.infradead.org> (raw)
In-Reply-To: <20180529143126.GA19698@jordon-HP-15-Notebook-PC>
On Tue, May 29, 2018 at 08:01:26PM +0530, Souptick Joarder wrote:
> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted, vm_fault_t will become a distinct type.
I don't believe you've checked this with sparse.
> @@ -802,7 +802,8 @@ int fixup_user_fault(struct task_struct *tsk, struct mm_struct *mm,
> bool *unlocked)
> {
> struct vm_area_struct *vma;
> - int ret, major = 0;
> + int major = 0;
> + vm_fault_t ret;
>
> if (unlocked)
> fault_flags |= FAULT_FLAG_ALLOW_RETRY;
...
major |= ret & VM_FAULT_MAJOR;
That should be throwing a warning.
next prev parent reply other threads:[~2018-05-29 14:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 14:31 [PATCH] mm: Change return type to vm_fault_t Souptick Joarder
2018-05-29 14:50 ` Matthew Wilcox [this message]
2018-05-29 15:55 ` Souptick Joarder
2018-05-29 17:34 ` Matthew Wilcox
2018-05-30 3:40 ` Souptick Joarder
2018-05-30 11:16 ` Matthew Wilcox
2018-06-02 14:44 ` Souptick Joarder
2018-06-02 14:44 ` Souptick Joarder
2018-06-02 14:55 ` Souptick Joarder
2018-06-02 14:59 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529145055.GA15148@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hughd@google.com \
--cc=jrdr.linux@gmail.com \
--cc=jschoenh@amazon.de \
--cc=kirill.shutemov@linux.intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=pasha.tatashin@oracle.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=ross.zwisler@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=yang.s@alibaba-inc.com \
--cc=zi.yan@cs.rutgers.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).