From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Dave Jiang <dave.jiang@intel.com>,
Toshi Kani <toshi.kani@hpe.com>,
linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
linux-xfs@vger.kernel.org, dm-devel@redhat.com,
linux-fsdevel@vger.kernel.org,
Ross Zwisler <ross.zwisler@linux.intel.com>
Subject: Re: [dm-devel] [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns
Date: Thu, 31 May 2018 15:26:45 -0700 [thread overview]
Message-ID: <20180531222645.GA6086@magnolia> (raw)
In-Reply-To: <20180531205206.GA12681@redhat.com>
On Thu, May 31, 2018 at 04:52:06PM -0400, Mike Snitzer wrote:
> On Thu, May 31 2018 at 3:13pm -0400,
> Darrick J. Wong <darrick.wong@oracle.com> wrote:
>
> > On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler wrote:
> > > On Tue, May 29, 2018 at 02:25:10PM -0700, Darrick J. Wong wrote:
> > > > On Tue, May 29, 2018 at 01:51:01PM -0600, Ross Zwisler wrote:
> > > > > From: Dave Jiang <dave.jiang@intel.com>
> > > > >
> > > > > The function return values are confusing with the way the function is
> > > > > named. We expect a true or false return value but it actually returns
> > > > > 0/-errno. This makes the code very confusing. Changing the return values
> > > > > to return a bool where if DAX is supported then return true and no DAX
> > > > > support returns false.
> > > > >
> > > > > Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> > > > > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> > > >
> > > > Looks ok, do you want me to pull the first two patches through the xfs
> > > > tree?
> > > >
> > > > Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> > >
> > > Thanks for the review.
> > >
> > > I'm not sure what's best. If you do that then Mike will need to have a DM
> > > branch for the rest of the series based on your stable commits, yea?
> > >
> > > Mike what would you prefer?
> >
> > I /was/ about to say that I would pull in the first two patches, but now
> > I can't get xfs to mount with pmem at all, and have no way of testing
> > this...?
>
> Once you get this sorted out, please feel free to pull in the first 2.
Sorted. It'll be in Friday's for-next. Ross helped me bang on the pmem
devices w/ ndctl to enable fsdax mode and twist qemu until everything
worked properly. ;)
--D
> I'm unlikely to get to reviewing the DM patches in this series until
> tomorrow at the earliest.
>
> Mike
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2018-05-31 22:27 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 19:50 [PATCH v2 0/7] Fix DM DAX handling Ross Zwisler
2018-05-29 19:51 ` [PATCH v2 1/7] fs: allow per-device dax status checking for filesystems Ross Zwisler
2018-05-29 19:51 ` [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns Ross Zwisler
2018-05-29 21:25 ` Darrick J. Wong
2018-05-29 22:01 ` Ross Zwisler
2018-05-31 19:13 ` Darrick J. Wong
2018-05-31 20:34 ` Ross Zwisler
2018-05-31 20:35 ` Dan Williams
2018-05-31 20:41 ` Ross Zwisler
2018-05-31 20:52 ` Mike Snitzer
2018-05-31 22:26 ` Darrick J. Wong [this message]
2018-06-01 20:59 ` [dm-devel] " Ross Zwisler
2018-06-01 1:26 ` Dave Chinner
2018-06-01 1:57 ` Dan Williams
2018-06-01 2:24 ` Dave Chinner
2018-06-01 4:02 ` Dan Williams
2018-06-03 22:20 ` Dave Chinner
2018-06-04 0:25 ` Dave Chinner
2018-06-04 1:48 ` Dan Williams
2018-06-04 23:40 ` Dan Williams
2018-06-05 0:33 ` Mike Snitzer
2018-06-05 5:55 ` Dave Chinner
2018-06-05 3:32 ` Dan Williams
2018-05-29 19:51 ` [PATCH v2 3/7] dm: fix test for DAX device support Ross Zwisler
2018-06-01 20:19 ` Mike Snitzer
2018-06-01 20:46 ` Mike Snitzer
2018-06-01 21:11 ` Ross Zwisler
2018-06-01 21:16 ` Dan Williams
2018-05-29 19:51 ` [PATCH v2 4/7] dm: prevent DAX mounts if not supported Ross Zwisler
2018-06-01 21:55 ` Mike Snitzer
2018-06-04 23:15 ` Ross Zwisler
2018-06-20 15:17 ` Mike Snitzer
2018-06-25 19:20 ` Ross Zwisler
2018-05-29 19:51 ` [PATCH v2 5/7] dm: remove DM_TYPE_DAX_BIO_BASED dm_queue_mode Ross Zwisler
2018-06-01 22:04 ` Mike Snitzer
2018-06-04 23:24 ` Ross Zwisler
2018-06-04 23:49 ` Kani, Toshi
2018-06-05 0:46 ` Mike Snitzer
2018-06-06 17:24 ` Ross Zwisler
2018-06-06 22:29 ` Mike Snitzer
2018-05-29 19:51 ` [PATCH v2 6/7] dm-snap: remove unnecessary direct_access() stub Ross Zwisler
2018-05-29 19:51 ` [PATCH v2 7/7] dm-error: " Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180531222645.GA6086@magnolia \
--to=darrick.wong@oracle.com \
--cc=dave.jiang@intel.com \
--cc=dm-devel@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ross.zwisler@linux.intel.com \
--cc=snitzer@redhat.com \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).