From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 7 Jun 2018 17:50:03 +0200 From: Jan Kara To: Dan Williams Cc: linux-nvdimm@lists.01.org, hch@lst.de, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, jack@suse.cz Subject: Re: [PATCH v3 04/12] device-dax: Set page->index Message-ID: <20180607155003.dwndud2xsnpqpcxl@quack2.suse.cz> References: <152815389835.39010.13253559944508110923.stgit@dwillia2-desk3.amr.corp.intel.com> <152815392126.39010.6403368422475215562.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152815392126.39010.6403368422475215562.stgit@dwillia2-desk3.amr.corp.intel.com> Sender: owner-linux-mm@kvack.org List-ID: On Mon 04-06-18 16:12:01, Dan Williams wrote: > In support of enabling memory_failure() handling for device-dax > mappings, set ->index to the pgoff of the page. The rmap implementation > requires ->index to bound the search through the vma interval tree. > > The ->index value is never cleared. There is no possibility for the > page to become associated with another pgoff while the device is > enabled. When the device is disabled the 'struct page' array for the > device is destroyed and ->index is reinitialized to zero. > > Signed-off-by: Dan Williams Looks good to me. You can add: Reviewed-by: Jan Kara Honza -- Jan Kara SUSE Labs, CR