From: Mark Fasheh <mfasheh@suse.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-xfs@vger.kernel.org, Adam Borowski <kilobyte@angband.pl>,
David Sterba <dsterba@suse.cz>
Subject: Re: [PATCH v3 1/2] vfs: allow dedupe of user owned read-only files
Date: Thu, 7 Jun 2018 22:45:44 +0200 [thread overview]
Message-ID: <20180607204544.GB28053@wotan.suse.de> (raw)
In-Reply-To: <20180607181751.GN25007@magnolia>
Hi Darrick,
On Thu, Jun 07, 2018 at 11:17:51AM -0700, Darrick J. Wong wrote:
> Looks ok, but could you please update the manpage for
> ioctl_fideduperange to elaborate on when userspace can expect EPERM?
>
> Acked-by: Darrick J. Wong <darrick.wong@oracle.com>
Yes, good idea. I can handle that.
Thanks,
--Mark
next prev parent reply other threads:[~2018-06-07 20:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 17:38 [PATCH v3 0/2] vfs: better dedupe permission check Mark Fasheh
2018-06-07 17:38 ` [PATCH v3 1/2] vfs: allow dedupe of user owned read-only files Mark Fasheh
2018-06-07 18:17 ` Darrick J. Wong
2018-06-07 20:45 ` Mark Fasheh [this message]
2018-06-07 17:38 ` [PATCH v3 2/2] vfs: dedupe should return EPERM if permission is not granted Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180607204544.GB28053@wotan.suse.de \
--to=mfasheh@suse.de \
--cc=darrick.wong@oracle.com \
--cc=dsterba@suse.cz \
--cc=kilobyte@angband.pl \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).